From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Sebastien Vauban
<public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org>
Cc: public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org
Subject: Re: [PATCH] Improve message when file to include is missing
Date: Tue, 18 Feb 2014 21:21:54 +0100 [thread overview]
Message-ID: <87ppmk2mu5.fsf@gmail.com> (raw)
In-Reply-To: <86bny4o4gz.fsf@somewhere.org> (Sebastien Vauban's message of "Tue, 18 Feb 2014 15:55:24 +0100")
Hello,
"Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:
> This should answer your (fruitful) comments.
Thank you for the update.
It looks good. AFAIC, you can push it.
> + (if (or (not file) (not (file-readable-p file)))
> + (if (not noerror)
> + (error "Cannot read file \"%s\"%s" file info-from-file)
> + (message "Cannot read file \"%s\"%s" file info-from-file))
> + (with-temp-buffer
> + (insert-file-contents file)
> + (buffer-string)))))
Minor stylistic issue: I find the following a bit easier to understand.
(if (and file (file-readable-p file))
(with-temp-buffer
(insert-file-contents file)
(buffer-string))
(funcall (if noerror #'message #'error)
"Cannot read file \"%s\"%s" file info-from-file))
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-02-18 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 10:49 [PATCH] Improve message when file to include is missing Sebastien Vauban
2014-01-24 11:14 ` Nicolas Goaziou
2014-01-24 11:19 ` Bastien
2014-02-18 14:55 ` Sebastien Vauban
2014-02-18 20:21 ` Nicolas Goaziou [this message]
2014-02-18 20:32 ` Sebastien Vauban
2014-02-18 22:10 ` Nicolas Goaziou
2014-01-24 11:15 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppmk2mu5.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=public-emacs-orgmode-mXXj517/zsQ@plane.gmane.org \
--cc=public-sva-news-D0wtAvR13HarG/iDocfnWg@plane.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).