From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: PATCH -- ox-latex.el . sideways figure in latex export
Date: Sun, 06 Apr 2014 10:46:18 +0200
Message-ID: <87ppku6e1x.fsf@gmail.com>
References: <5CE478C5-C4A2-4BA7-B197-4807EAFE4B18@gmail.com>
	<8738hr7g52.fsf@gmail.com>
	<CAFxtbJBbizVHyRUfC_c2ADsMuhsTnTWOuvX=dX0+Lmh9=ApXjw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1WWiiD-0008Q5-02
	for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 04:46:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1WWii7-0003p5-3o
	for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 04:45:56 -0400
Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:38295)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1WWii6-0003ox-SK
	for emacs-orgmode@gnu.org; Sun, 06 Apr 2014 04:45:51 -0400
Received: by mail-wg0-f49.google.com with SMTP id a1so5496892wgh.32
	for <emacs-orgmode@gnu.org>; Sun, 06 Apr 2014 01:45:49 -0700 (PDT)
In-Reply-To: <CAFxtbJBbizVHyRUfC_c2ADsMuhsTnTWOuvX=dX0+Lmh9=ApXjw@mail.gmail.com>
	(Greg Tucker-Kellogg's message of "Sun, 6 Apr 2014 12:10:54 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Greg Tucker-Kellogg <gtuckerkellogg@gmail.com>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>

Hello,

Greg Tucker-Kellogg <gtuckerkellogg@gmail.com> writes:

> I think this covers it.  ":float sideways" now works for both tables and
> figures, but ":float sidewaystable" is kept for backwards compatibility.  I
> updated org.texi, and mentioned that the use of ":float sideways" will make
> the ":placement" option irrelevant.
>
> Attached are the two patches; the one from yesterday and the one that
> updates as described above.

Thank you. Here are a few comments.

> +The @code{:float} specifies the float environment for the table.  Possible values are @code{sideways},
> +(or equivalently @code{sidewaystable}), @code{multicolumn}, @code{t} and @code{nil}.  When unspecified, a table with
> +a caption will have a @code{table} environment.  Moreover, the @code{:placement}
> +attribute can specify the positioning of the float. Note: @code{:placement} is
> +ignored for sidewaystable.

In Texinfo, you need to add two spaces after a period.

Also, providing backwards compatibility for "sidewaystable" in code is
fine, but I don't think we need to talk about it anymore as an
alternative option in the documentation. If you feel uncomfortable about
it, I think it's better to add a footnote:

  Possible values are @code{sideways}@footnote{Formerly, the value was
  @code{sidewaystable}.  This is deprecated since Org 8.3.},
  @code{multicolumn}...

Also, could you provide a proper commit message, with "TINYCHANGE" at
its end. For more information, see

  http://orgmode.org/worg/org-contribute.html

I think you can also merge both patches. But that's your call.


Regards,

-- 
Nicolas Goaziou