From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [PATCH] Making org-agenda filters orthogonal and refreshed
Date: Sat, 19 Apr 2014 08:02:10 +0200
Message-ID: <87ppkdg8m5.fsf@bzg.ath.cx>
References: <CAFxtbJDeyfq+rMJxEOZApze5LH=o+OKEHdO5+=z--9Y9XLfuFg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53457)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbOM3-0000PG-Vo
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 02:02:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbOLu-0002En-Sr
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 02:02:23 -0400
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:42318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbOLu-0002Ef-Ma
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 02:02:14 -0400
Received: by mail-wi0-f181.google.com with SMTP id hm4so199676wib.2
	for <emacs-orgmode@gnu.org>; Fri, 18 Apr 2014 23:02:13 -0700 (PDT)
In-Reply-To: <CAFxtbJDeyfq+rMJxEOZApze5LH=o+OKEHdO5+=z--9Y9XLfuFg@mail.gmail.com>
	(Greg Tucker-Kellogg's message of "Sat, 19 Apr 2014 09:53:08 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Greg Tucker-Kellogg <gtuckerkellogg@gmail.com>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>

Hi Greg,

Greg Tucker-Kellogg <gtuckerkellogg@gmail.com> writes:

> This is org-mode version 8.2.5h, directly off the git.

When mentioning the Org version for a patch you submit, please
include the whole version with C-u M-x org-version RET -- this
tells more than C-h v org-version.

> emacs version 24.4.50.1
>
> I have noticed that combining top headline filters and category
> filters didn't always work as documented.

Thanks for looking into this.

Before we go further enhancing the patch, are you willing to go with
the FSF copyright assignment?  I see you already have tiny changes and
we cannot accept more.  If you're not willing to sign, you'll drive
the debugging and I'll write the code.

Let me know.

Other than that, the diagnosis is good and the patch looks okay,
except for the use of defadvice.

Thanks,

-- 
 Bastien