emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Greg Tucker-Kellogg <gtuckerkellogg@gmail.com>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Making org-agenda filters orthogonal and refreshed
Date: Sat, 19 Apr 2014 08:02:10 +0200	[thread overview]
Message-ID: <87ppkdg8m5.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CAFxtbJDeyfq+rMJxEOZApze5LH=o+OKEHdO5+=z--9Y9XLfuFg@mail.gmail.com> (Greg Tucker-Kellogg's message of "Sat, 19 Apr 2014 09:53:08 +0800")

Hi Greg,

Greg Tucker-Kellogg <gtuckerkellogg@gmail.com> writes:

> This is org-mode version 8.2.5h, directly off the git.

When mentioning the Org version for a patch you submit, please
include the whole version with C-u M-x org-version RET -- this
tells more than C-h v org-version.

> emacs version 24.4.50.1
>
> I have noticed that combining top headline filters and category
> filters didn't always work as documented.

Thanks for looking into this.

Before we go further enhancing the patch, are you willing to go with
the FSF copyright assignment?  I see you already have tiny changes and
we cannot accept more.  If you're not willing to sign, you'll drive
the debugging and I'll write the code.

Let me know.

Other than that, the diagnosis is good and the patch looks okay,
except for the use of defadvice.

Thanks,

-- 
 Bastien

  reply	other threads:[~2014-04-19  6:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-19  1:53 [PATCH] Making org-agenda filters orthogonal and refreshed Greg Tucker-Kellogg
2014-04-19  6:02 ` Bastien [this message]
2014-04-19  8:53   ` Greg Tucker-Kellogg
2014-04-19  9:06     ` Bastien
2014-05-22 11:39 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppkdg8m5.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=gtuckerkellogg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).