From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trevor Murphy Subject: Bug: Commit cece23 'fix'-ed call to 'type' breaks my agenda sorting [8.2.7 (8.2.7-elpa @ /home/trevor/.emacs.d/elpa/org-20140613/)] Date: Sat, 14 Jun 2014 11:56:53 -0400 Message-ID: <87ppibpjqy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvqKK-0002la-Ex for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 11:57:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvqKB-0001Eq-A8 for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 11:57:08 -0400 Received: from mail-yh0-x22f.google.com ([2607:f8b0:4002:c01::22f]:52158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvqKB-0001DP-68 for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 11:56:59 -0400 Received: by mail-yh0-f47.google.com with SMTP id v1so3074410yhn.20 for ; Sat, 14 Jun 2014 08:56:58 -0700 (PDT) Received: from organize (z65-50-91-81.ips.direcpath.com. [65.50.91.81]) by mx.google.com with ESMTPSA id s6sm11720242yhk.22.2014.06.14.08.56.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Jun 2014 08:56:55 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi, all! The commit named in the subject line is causing me grief. Specifically, the commit made three changes to the `org-cmp-ts' function: 1. Change the function signature to require the `type' argument. Doesn't cause me any issues. 2 & 3. Make two changes from (get-text-property 1 'type FOO) to (get-text-property 1 type FOO). These cause problems for me. Near as I can tell, get-text-property really is supposed to look up the `type' property of FOO (returning "scheduled" or "deadline" or w/e) so the function can check that against the restriction passed in through the argument. This commit has the function checking the `scheduled', `deadline', or other property of FOO based on the passed-in argument. In this case get-text-property always returns nil and the function never returns anything useful. Steps to reproduce: (setq org-agenda-sorting-strategy '((agenda deadline-up))) [pull up an agenda view with some deadline entries and some other stuff] (setq org-agenda-sorting-strategy '((agenda deadline-down))) [refresh the same agenda view] What I expect to see: Deadline entries flipping from top to bottom of the agenda view. What I actually see: No changes ... org-agenda-sorting-strategy doesn't appear to do anything. Is this affecting anybody else? Emacs : GNU Emacs 24.3.1 (i686-pc-linux-gnu, GTK+ Version 3.10.7) of 2014-01-28 on var-lib-archbuild-extra-i686-juergen Package: Org-mode version 8.2.7 (8.2.7-elpa @ /home/trevor/.emacs.d/elpa/org-20140613/) -- Trevor Murphy GnuPG Key: 0x83881C0A