Re: A recent mobile org change causing sync issues

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

Steve Harman <stvharman@gmail.com> writes:

> Thanks Nicolas,
>
> I am not able to post the diff due to the personal nature of the data.
> However, I can say that with the commit, the tags in the #+TAGS line is
> missing. Also, a link to one of the org files is missing.

Note that the commit alters neither TAGS lines nor links.

> Would it be possible to revert this change?

This change was introduced to fix a bug. Reverting it would break
"org-mobile.el" in another way. The problem was reported but no one, so
far, was able to investigate and tell what is wrong in the patch.

> This is such a critical bug and it really disrupted many of ours
> personal workflows.

I sympathize. Unfortunately, it seems that no Org developer is actually
using "org-mobile.el" or knows its internal. Apparently, mobileOrg
expects a specific format for index.org, but it is not documented

> It also embarrassed us towards our colleagues,
> families, and friends who held the view that proprieatary solutions
> are better.

I wouldn't bother about people thinking that proprietary solutions are
better.

> In general, it is preferable to have a test suite which should pass before
> releasing these commits. Yes, there is MELPA stable but not every package
> is on MELPA.

What do you want to test? We don't even know what output is expected. In
any case, if you implement some tests, feel free to submit them to this
ML.

Meanwhile, would the following patch fix the issue?


Regards,

-- 
Nicolas Goaziou

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-mobile-Fix-c15db80e32d22dace184203f6f03a0b586bb4.patch --]
[-- Type: text/x-diff, Size: 914 bytes --]

From 9a88fa0859075aae10a6cd90fb03d533acee1f6b Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Sat, 24 Oct 2015 11:15:31 +0200
Subject: [PATCH] org-mobile: Fix c15db80e32d22dace184203f6f03a0b586bb4b50

* lisp/org-mobile.el (org-mobile-create-index-file): Fix
  c15db80e32d22dace184203f6f03a0b586bb4b50.
---
 lisp/org-mobile.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 6c7c8d0..17600bd 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -439,8 +439,8 @@ agenda view showing the flagged items."
 	(if org-mobile-use-encryption
 	    org-mobile-encryption-tempfile
 	  target-file)
-      (insert "#+READONLY\n")
       (while (setq entry (pop def-todo))
+	(insert "#+READONLY\n")
 	(setq kwds (mapcar (lambda (x) (if (string-match "(" x)
 					   (substring x 0 (match-beginning 0))
 					 x))
-- 
2.6.1