emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: George M Jones <eludom@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: How to add a test?
Date: Sun, 28 Feb 2016 16:10:33 +0100	[thread overview]
Message-ID: <87povguaza.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r3fxnkes.fsf@pobox.com> (George M. Jones's message of "Sun, 28 Feb 2016 06:28:43 -0500")

Hello,

George M Jones <eludom@gmail.com> writes:

> What's the process for adding a test (specifically to babel)?
>
> The only part that looks non-obvious is how to generate the test ID,
> e.g. in ob-shell-test.org:
>
>   * Associative array tests (simple map)
>     :PROPERTIES:
>     :ID:       bec1a5b0-4619-4450-a8c0-2a746b44bf8d
>     :END:
>
> From there it looks like you just add to the correct file in
> org-mode/testing/examples/*.org and the corresponding
> /org-mode/testing/lisp/test-*.el file.  Am I missing anything?
>
> I'll add to the README or docs unless it's already there.

I suggest to stay away from examples/ and `org-test-at-id' altogether.
I find these tests horrible to debug when something goes wrong.

I suggest to stay with `org-test-with-temp-text', or, if needed,
`org-test-with-temp-text-in-file' and make the test self-contained.
Also, I think it is better to have only one `should' or related, outside
of this macro, so the whole test is easier to evaluate partially. See,
e.g., "test-org-footnote.el".

Obviously YMMV and the more important thing is to have more tests. How
tests are written is a lesser matter. Feel free to ignore my
suggestions.

Thank you for your work.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-02-28 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.121.1456506036.25421.emacs-orgmode@gnu.org>
2016-02-28 11:28 ` How to add a test? George M Jones
2016-02-28 15:10   ` Nicolas Goaziou [this message]
2016-02-29 16:40     ` John Kitchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87povguaza.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=eludom@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).