From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] New header parameter :show-process for Org-babel-clojure
Date: Fri, 18 Nov 2016 16:51:36 +0100
Message-ID: <87polsn5vb.fsf@nicolasgoaziou.fr>
References: <036bf007-5e9c-310c-5bf8-0660c1b96a5c@fgiasson.com>
	<87lgwrgy7z.fsf@nicolasgoaziou.fr>
	<794c93aa-e2dc-2bfb-537e-0c89d8d34cea@fgiasson.com>
	<878tslp4ha.fsf@nicolasgoaziou.fr>
	<27089048-9dab-747f-51dc-20006717866e@fgiasson.com>
	<87inrlogee.fsf@nicolasgoaziou.fr>
	<1339fd1b-c946-ac03-7ce8-0f82ac2de8a5@fgiasson.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c7lRw-000526-NP
	for emacs-orgmode@gnu.org; Fri, 18 Nov 2016 10:51:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c7lRw-0005O7-2t
	for emacs-orgmode@gnu.org; Fri, 18 Nov 2016 10:51:36 -0500
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:48952)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1c7lRv-0005Nc-SN
	for emacs-orgmode@gnu.org; Fri, 18 Nov 2016 10:51:35 -0500
In-Reply-To: <1339fd1b-c946-ac03-7ce8-0f82ac2de8a5@fgiasson.com> (Frederick
	Giasson's message of "Fri, 18 Nov 2016 10:12:51 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Frederick Giasson <fred@fgiasson.com>
Cc: emacs-orgmode@gnu.org

Hello,

Frederick Giasson <fred@fgiasson.com> writes:

> Hi Nicolas,
>>    In end of data:
>>    ob-clojure.el:180:1:Warning: the following functions are not known to be
>>        defined: nrepl-request:eval, nrepl--merge, nrepl-dict-put
>>
>> Could you look into it? In particular, "nrepl--merge" looks like an
>> internal function from nrepl. Is it safe to use it?
>
> Yes, these functions are part of Cider's nrepl. Yes, they should be
> safe. Also, they are only used in a context where the code block uses
> Cider as the backend, so I guess it is right to use them in that
> context. Thoughts?

They should be declared at the beginning of "ob-clojure.el" (see
nrep-dict-get for example).

Also an internal function means its signature can change, or it can be
removed, without prior notice. If there is no "public" API for
"nrepl--merge", then so be it.


Regards,

-- 
Nicolas Goaziou