From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [Patch] Support for dimming local to each agenda
Date: Fri, 14 Jul 2017 11:39:51 +0200
Message-ID: <87pod3cq6w.fsf@nicolasgoaziou.fr>
References: <CAC38U-cThtaELpmhUefQHtkjvDdcWyhP8vpsn_YiWMdj6ORJdQ@mail.gmail.com>
	<8760ewfqja.fsf@nicolasgoaziou.fr>
	<CAC38U-dTU0X-Ka9fvxPH+9DDaTv=jDLmZrZGLXpx+k=Kq3Bc=w@mail.gmail.com>
	<87k23be81f.fsf@nicolasgoaziou.fr>
	<CAC38U-camWfm48pXnAyBcgUHEvhGNCW7TjEUr9CdSXs_mV_TOg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33599)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dVx4n-0006Jb-0c
	for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 05:39:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dVx4m-0007Mn-9G
	for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 05:39:57 -0400
Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:34030)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dVx4m-0007MP-3L
	for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 05:39:56 -0400
In-Reply-To: <CAC38U-camWfm48pXnAyBcgUHEvhGNCW7TjEUr9CdSXs_mV_TOg@mail.gmail.com>
	(Yuri Lensky's message of "Fri, 14 Jul 2017 02:22:50 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Yuri Lensky <ydl@ydl.cm>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Yuri Lensky <ydl@ydl.cm> writes:

> Why not save mark? 

We usually do not mess with it, unless this is explicit in the function
documentation, e.g., `org-mark-ring-push'.

> This allows user-defined hooks in org-blocker-hooks more freedom.

I'm not sure this is a sufficient reason, really. Besides it's
debatable.

> That said, I am not sure of org-mode project conventions, so if
> `save-excursion' is preferred I can change it to that.

I'm going to do the change myself and apply you patch. No need for
another iteration.

Thank you!

Regards,