emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Strike-through messes with heading face [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/local/share/emacs/27.0.50/lisp/org/)]
Date: Sat, 27 Apr 2019 18:55:32 +0200	[thread overview]
Message-ID: <87pnp7fkvv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r2a4ztt2.fsf@gmail.com> ("Kévin Le Gouguec"'s message of "Sun, 14 Apr 2019 13:54:01 +0200")

Hello,

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

> Unless I am mistaken, +strike-through+ markers in headings cause the
> heading face to disappear.  To reproduce, in an Org buffer, add the
> following heading:
>
>     * foo *bar* /baz/ _quux_ +corge+
>
> Testing this with emacs -Q, on commit f9694a7 of the master branch,
> bar (resp. baz and quux) displays the org-level-1 face as well as the
> bold (resp. italics and underlined) decoration, but not corge: the
> latter only shows the strike-through decoration, not the header face.
>
> I poked at org-do-emphasis-faces with the silly patch attached, and
> the issue went away (corge shows both the header face and the
> strike-through decoration).
>
> diff --git a/lisp/org.el b/lisp/org.el
> index b5b9798ad..94713a7e5 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5064,7 +5064,7 @@ stacked delimiters is N.  Escaping delimiters is not possible."
>  		   (not (and (save-match-data (org-match-line "[ \t]*|"))
>  			     (string-match-p "|" (match-string 4))))))
>  	    (pcase-let ((`(,_ ,face ,_) (assoc marker org-emphasis-alist)))
> -	      (font-lock-prepend-text-property
> +	      (font-lock-append-text-property
>  	       (match-beginning 2) (match-end 2) 'face face)
>  	      (when verbatim?
>  		(org-remove-flyspell-overlays-in

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2019-04-27 16:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 11:54 Bug: Strike-through messes with heading face [9.1.9 (release_9.1.9-65-g5e4542 @ /usr/local/share/emacs/27.0.50/lisp/org/)] Kévin Le Gouguec
2019-04-27 16:55 ` Nicolas Goaziou [this message]
2019-04-28 16:31   ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnp7fkvv.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin.legouguec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).