emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [QUESTION] A decision about matching ob-sql.el's :engine header argument match sql-mode product name
@ 2020-01-30  6:21 stardiviner
  2020-01-30  7:29 ` Tim Cross
  0 siblings, 1 reply; 9+ messages in thread
From: stardiviner @ 2020-01-30  6:21 UTC (permalink / raw)
  To: Org Mode, Nicolas Goaziou


I'm writing a patch which try to set ~sql-product~ when editing sql src block.

Here is the code:

#+begin_src emacs-lisp
(defun org-babel-edit-prep:sql (info)
  "Set `sql-product' in Org edit buffer.
Set `sql-product' in Org edit buffer according to the
corresponding :engine source block header argument."
  (let ((product (cdr (assq :engine (nth 2 info)))))
    (sql-set-product product)))
#+end_src

But =ob-sql.el= source code hardcoded ~:engine~ names which some are not matched
with ~sql-product-alist~ in =sql-mode=. For example =:engine postgresql=, but it's
~postgres~ in ~sql-product-alist~.

For now, I have two solutions:

1. write an adapter function which translate ~:engine~ header argument value into
   ~sql-product-alist~ product names. This is a safe way, which will not
   incompatiable with old Org document.

2. modify source code hardcoded ~:engine~ names (also need to update Org
   document), this has a minor advantage is *consistance*.

WDYT?

BTW, about writing an adapter function to translate names. I want to hear some
suggestion about use which method. Writing an hash map or assoc list etc?

Regards

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-02-12  8:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30  6:21 [QUESTION] A decision about matching ob-sql.el's :engine header argument match sql-mode product name stardiviner
2020-01-30  7:29 ` Tim Cross
2020-01-30 12:32   ` stardiviner
2020-01-31 10:53     ` Bastien
2020-02-04 16:29       ` [PATCH] ob-sql.el support auto set sql-product in editing sql-mode src block buffer stardiviner
2020-02-05 15:46         ` stardiviner
2020-02-12  7:11         ` stardiviner
2020-02-12  8:06           ` Bastien
2020-02-12  8:41             ` [SOLVED] " stardiviner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).