From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Kamm Subject: Re: A few changes to test in master Date: Fri, 07 Feb 2020 18:14:03 -0800 Message-ID: <87pnepesgk.fsf@gmail.com> References: <87wo9750jl.fsf@gnu.org> <87a75yrdye.fsf@gmail.com> <87sgjpd059.fsf@bzg.fr> <87y2tequa6.fsf@gmail.com> <87wo8ycrcx.fsf@bzg.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:58238) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0FeI-0000MY-3f for emacs-orgmode@gnu.org; Fri, 07 Feb 2020 21:15:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0FeG-0007OW-UU for emacs-orgmode@gnu.org; Fri, 07 Feb 2020 21:15:09 -0500 In-Reply-To: <87wo8ycrcx.fsf@bzg.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Hi Bastien, Bastien writes: >> I have noticed a new bug, where the header line randomly gets "stuck" >> on some row of the table, so even when I scroll and that row is no >> longer on top of the buffer, that row is still replaced by the header >> line. > > Yes, fixed now. Hmm, I'm experience the problem worse now -- the header is always getting stuck on the first row it appears on. Also, I'm seeing the follow error in my *Messages*: Error in post-command-hook (org-table-header-set-header): (error "Invalid or uninitialized timer") >> Thanks. The default face looks great on light-themed backgrounds like >> leuven, but is hard to read on some dark-themed backgrounds like >> tsdh-dark or zenburn, due to their light text. Maybe the simplest >> solution would be to set both the background and foreground colors in >> the default face? > > Sure - would you like to suggest a patch for this? Sure, see the patch below. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-org-faces.el-Add-foreground-color-to-org-table-heade.patch >From 2922d104b3508b1269c17ad0a28103bd912e308b Mon Sep 17 00:00:00 2001 From: Jack Kamm Date: Fri, 7 Feb 2020 18:04:59 -0800 Subject: [PATCH] org-faces.el: Add foreground color to org-table-header face * lisp/org-faces.el (org-table-header): Add foreground color to org-table-header face, to ensure readability when using a dark theme. --- lisp/org-faces.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-faces.el b/lisp/org-faces.el index d50f715cc..d78b606ec 100644 --- a/lisp/org-faces.el +++ b/lisp/org-faces.el @@ -364,7 +364,9 @@ changes." "Face used for tables." :group 'org-faces) -(defface org-table-header '((t :inherit org-table :background "LightGray")) +(defface org-table-header '((t :inherit org-table + :background "LightGray" + :foreground "Black")) "Face for table header." :group 'org-faces) -- 2.25.0 --=-=-=--