Re: A few changes to test in master

[Jack Kamm <jackkamm@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

Hi Bastien,

Bastien <bzg@gnu.org> writes:

>> I have noticed a new bug, where the header line randomly gets "stuck"
>> on some row of the table, so even when I scroll and that row is no
>> longer on top of the buffer, that row is still replaced by the header
>> line.
>
> Yes, fixed now.

Hmm, I'm experience the problem worse now -- the header is always
getting stuck on the first row it appears on. Also, I'm seeing the
follow error in my *Messages*:

Error in post-command-hook (org-table-header-set-header): (error "Invalid or uninitialized timer")

>> Thanks. The default face looks great on light-themed backgrounds like
>> leuven, but is hard to read on some dark-themed backgrounds like
>> tsdh-dark or zenburn, due to their light text. Maybe the simplest
>> solution would be to set both the background and foreground colors in
>> the default face?
>
> Sure - would you like to suggest a patch for this?

Sure, see the patch below.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-faces.el-Add-foreground-color-to-org-table-heade.patch --]
[-- Type: text/x-patch, Size: 912 bytes --]

From 2922d104b3508b1269c17ad0a28103bd912e308b Mon Sep 17 00:00:00 2001
From: Jack Kamm <jackkamm@gmail.com>
Date: Fri, 7 Feb 2020 18:04:59 -0800
Subject: [PATCH] org-faces.el: Add foreground color to org-table-header face

* lisp/org-faces.el (org-table-header): Add foreground color to
org-table-header face, to ensure readability when using a dark theme.
---
 lisp/org-faces.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/org-faces.el b/lisp/org-faces.el
index d50f715cc..d78b606ec 100644
--- a/lisp/org-faces.el
+++ b/lisp/org-faces.el
@@ -364,7 +364,9 @@ changes."
   "Face used for tables."
   :group 'org-faces)
 
-(defface org-table-header '((t :inherit org-table :background "LightGray"))
+(defface org-table-header '((t :inherit org-table
+			       :background "LightGray"
+			       :foreground "Black"))
   "Face for table header."
   :group 'org-faces)
 
-- 
2.25.0