org-set-tags function will overwrite original tags when use it pragmatically

org-set-tags function will overwrite original tags when use it pragmatically

[stardiviner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


I use function ~org-set-tags~ pragmatically like this:

#+begin_src emacs-lisp
(defun my/org-add-note--auto-add-tag ()
  "Auto add tag 'NOTE' when add note log."
  (org-back-to-heading)
  (org-set-tags '("LOG")))
(advice-add 'org-add-note :after #'my/org-add-note--auto-add-tag)
#+end_src

But I found a problem, it will overwrite original tags. It's not appending method.

I hope this function can be improve to suitable for this purpose. What about and
optional argument of this function to decide overwrite or append method?

Thanks in advance.

- -- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl6j5ygUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsM1lwgArs5bGY3res7ejZM1kaOVLGtMMpdK
4uMIlJAgf6F9Kn2c4owImC88we6/IPK0TVOMISKBY30ZCIiFq2OMMhuwAOTXICmT
kx8New5B1k8XuFFxNYH2QxxNR1taYXQrfXyBHtXGjAXtPkY0hscXGt4FIsZY71Tj
2zGPxtb47WY6KIapuqqi6KEyG5DgABgsFvF6mpjYmDe0tsC6POjQA3FkfdsxhQzX
sBbVJHD8bvrVcROGlyTc8xXjUTwRXz2WlAB38rDebq/QqFbPcrVixxonHwp7h2eM
bzSvg0oombEUQp/+j+kU23Y96p7kTTaFl9VE0Ynb2hNSjbGRU9BlafhwLg==
=3MMP
-----END PGP SIGNATURE-----

Re: org-set-tags function will overwrite original tags when use it pragmatically

[Nicolas Goaziou]

Hello,

stardiviner <numbchild@gmail.com> writes:

> I use function ~org-set-tags~ pragmatically like this:

[...]

> But I found a problem, it will overwrite original tags. It's not appending method.

Well, it is expected according to its docstring, isn't it?

> I hope this function can be improve to suitable for this purpose. What about and
> optional argument of this function to decide overwrite or append
> method?

I think 

  (org-set-tags (cons "LOG" (org-get-tags nil t)))

is enough. No need to add arguments.

Regards,

-- 
Nicolas Goaziou

[SOLVED] Re: org-set-tags function will overwrite original tags when use it pragmatically

[stardiviner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> I use function ~org-set-tags~ pragmatically like this:
>
> [...]
>
>> But I found a problem, it will overwrite original tags. It's not appending method.
>
> Well, it is expected according to its docstring, isn't it?
>
>> I hope this function can be improve to suitable for this purpose. What about and
>> optional argument of this function to decide overwrite or append
>> method?
>
> I think 
>
>   (org-set-tags (cons "LOG" (org-get-tags nil t)))
>
> is enough. No need to add arguments.

This is great, thanks, Nicolas.


- -- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl6kSo4UHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsP1rwgAg+zG8LIWq8W87pCLFqS6BHH+y4Zy
zHMGpYUmIIfsLXrhDWyJCaEnABNICq7zTZV1Qa3UNt7vR5kapp7GuBzdFefcVjjx
+QPG19YUDRD2Xr6U6MrJxXrvLBXcawsemZ+5eAJTC9oD6P38iCXvDO0r7rtBXYvd
/OBiKw+Oih7Vlr0wqTAbBO2MKicPQmb8lhRQQlbUoy8SFN80dA3ih1bRsMfP2NX8
1knKruhi007WK2KVdAv90wa5m+FPHW2fLliz07QHv5b84YUOgK8I7UnRXr0wdwww
IjmuWcF6iyOpysE5tHeGXZwugz0vgxDAayfHKsXwKuGVEczv2GGRzA62bQ==
=QRtm
-----END PGP SIGNATURE-----