From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0LXnDW0MAF//NQAA0tVLHw (envelope-from ) for ; Sat, 04 Jul 2020 04:58:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KGePCW0MAF8WVwAA1q6Kng (envelope-from ) for ; Sat, 04 Jul 2020 04:58:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E1629400BF for ; Sat, 4 Jul 2020 04:58:20 +0000 (UTC) Received: from localhost ([::1]:44582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jraFm-0001nj-Q8 for larch@yhetil.org; Sat, 04 Jul 2020 00:58:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jraFR-0001nP-4Z for emacs-orgmode@gnu.org; Sat, 04 Jul 2020 00:57:57 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:45193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jraFP-0000Jj-2g for emacs-orgmode@gnu.org; Sat, 04 Jul 2020 00:57:56 -0400 Received: by mail-pl1-x641.google.com with SMTP id g17so13309479plq.12 for ; Fri, 03 Jul 2020 21:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=KGrfAbupV6uHZNejAwH12C8stcnmO0OiLK2vei9qU+o=; b=Uxcbyp9jAt/vBXhzu1eY5UheHhSlgXe2YwuORe5xpyn5tof0cntoP607QJX3+e1kv+ 327pcAZJ0w6ikbfdc2fDyad88/PVMv+aVaX/GQs++TBUAGG4DBiFW9d7X6orhc71QZtl S3WW5CEpYqgh5Vb7jc7amnrmq7DsB2nfZxuGJsQs5vuNZnW07FkAhr3NzHZPf53a5txx W56L5nUH05gvanCkNrQO+MZ403xc1MVdQhIs+6SrcLfrBKOU64OZBxsh5x2rgno6TIX3 q5LZoVW6XRkhoxXw22AMHE4aGWG+2VI8drSfA8nnKJDsUHQLjhF5sjiOFjTQ0s5O0xJH nbsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=KGrfAbupV6uHZNejAwH12C8stcnmO0OiLK2vei9qU+o=; b=CpN2Bp6tdAPnke5XHYY+DAnmR12rmTRllUT49BUXuKVniphsgoByOlotNvf+2wjJ8B Ok4d3h58huGhCeqBYcmzOyN10hgc8EE63JJ15ulO13/DnpdYbgXG9hOGr9k3gZzIkm0u hK+Za0mHxV8Ki/7qM1idsvpSvIsOcIknpCiRIfkp4Ls8F+7mWodi24ZszHCOPJMToqO6 +Jf6RZvE6FxTR+n3XK+4PEHAkEvu8zkt8RcUXWAGWnAfKH2kYGjl+Idd5in9ajqYsm70 5RuFdZkVDhZmECxSDkWlxTFC6ZPvJ/sLSqZrv2pI3DXlZCSURpoN1p8nEBvjwlnk19Dc ue2A== X-Gm-Message-State: AOAM530gQQmkfkvtl/GwhjE00C2nHM78Cb8UOoCkVR37NIs9lE4j04rz O1SfHRfJkumXL1aepmNz4kg= X-Google-Smtp-Source: ABdhPJwMIgr930hNwDbC+LChhrraM+IW55OyGoPTQI7dH82t/SlxfFsFrnQRxdnhvXgv1OJow47abQ== X-Received: by 2002:a17:902:b603:: with SMTP id b3mr33835832pls.1.1593838673400; Fri, 03 Jul 2020 21:57:53 -0700 (PDT) Received: from localhost (97.151-89-23.rdns.scalabledns.com. [23.89.151.97]) by smtp.gmail.com with ESMTPSA id 22sm13033962pfx.94.2020.07.03.21.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 21:57:52 -0700 (PDT) From: Ihor Radchenko To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec , emacs-orgmode@gnu.org Subject: Re: [9.4] LOGBOOK visibility In-Reply-To: <87r1ts3s8r.fsf@localhost> References: <87eepuz0bj.fsf@gmail.com> <87wo3kk8x1.fsf@gmail.com> <87pn9cihul.fsf@gmail.com> <87r1ts3s8r.fsf@localhost> Date: Sat, 04 Jul 2020 12:57:35 +0800 Message-ID: <87pn9b98sg.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=yantar92@gmail.com; helo=mail-pl1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Uxcbyp9j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: JYzWygR6heo4 > Meanwhile, you may, for example, advice > org-fold--isearch-filter-predicate to re-fold drawers during isearch.=20 org-fold--isearch-filter-predicate->isearch-filter-visible Ihor Radchenko writes: >> I haven't reached the bottom of this rabbit hole yet. Since I think >> I've spent all the time I had to spend in this issue for the day, here's >> where I'm at. > > There used to be several types of overlays for headline folding, drawer > folding, and block folding. One of the recent commits made all the > overlays use headline type. As a result all the overlays are merged into > a single overlay upon folding. This was done to reduce the total number > of overlays present in an org buffer, which degrades Emacs performance > on huge org files (see the discussion in [1]).=20 > > What you observe is a consequence of that change. Now, all the drawer > overlays are destroyed when you fold a heading. Isearch would > only see a single huge overlay and unfold it alltogether. > > I am currently working on a patch to rewrite the whole folding system. > Your issue should disappear once it is applied. > > Meanwhile, you may, for example, advice > org-fold--isearch-filter-predicate to re-fold drawers during isearch.=20 > > Best, > Ihor > > [1] https://www.mail-archive.com/emacs-orgmode@gnu.org/msg127740.html > > K=C3=A9vin Le Gouguec writes: > >> I haven't reached the bottom of this rabbit hole yet. Since I think >> I've spent all the time I had to spend in this issue for the day, here's >> where I'm at. >> >> If I open my example file[1] with Org 9.3 and master (86fada6b5), and >> compare the overlays covering the hidden part of the first LOGBOOK >> drawer, like so: >> >> #+begin_src sh >> #!/bin/bash >> >> set -eu >> >> point=3D67 >> >> orgs=3D( >> "${path_to_org_9_3}" >> "${path_to_org_master}" >> ) >> >> for o in "${orgs[@]}" >> do >> emacs -Q -batch \ >> -L "${o}"/lisp \ >> -eval "(find-file \"logbooks.org\")" \ >> -eval "(message org-version)" \ >> -eval "(dolist (o (overlays-at ${point})) >> (message \"from %s to %s\" (overlay-start o) (overlay= -end o)) >> (message \"%s\" (overlay-properties o)))" >> echo >> done >> #+end_src >> >> Here is what I get: >> >>> 9.3 >>> from 32 to 2015 >>> (evaporate t invisible outline isearch-open-invisible #[lambda gibberis= h involving (org-show-context 'isearch)]) >>> from 67 to 262 >>> (isearch-open-invisible delete-overlay invisible org-hide-drawer evapor= ate t) >>>=20 >>> 9.3.7 >>> from 32 to 2015 >>> (isearch-open-invisible delete-overlay invisible outline evaporate t) >> >> - The LOGBOOK overlay (from 67 to 262) vanished. >> >> - The isearch-open-invisible property of the "project 1" overlay (from >> 32 to 2015) changed from a lambda[2] to just delete-overlay. >> >> >> Again, not sure this shows there's an issue; for all I know Org 9.4 just >> works differently and nothing's wrong there. I hope someone can chime >> in and take it up from here; otherwise I'll resume my investigations >> sometime later. >> >> >> [1] https://orgmode.org/list/87eepuz0bj.fsf@gmail.com/2-logbooks.org >> >> [2] Which I guess is the value of >> outline-isearch-open-invisible-function, set locally by org-mode in >> the major mode function? >> > > --=20 > Ihor Radchenko, > PhD, > Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) > State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong= University, Xi'an, China > Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg --=20 Ihor Radchenko, PhD, Center for Advancing Materials Performance from the Nanoscale (CAMP-nano) State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong U= niversity, Xi'an, China Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg