From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id PxUzMlnAHV9JCQAA0tVLHw (envelope-from ) for ; Sun, 26 Jul 2020 17:41:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8BN0LVnAHV/KUwAAB5/wlQ (envelope-from ) for ; Sun, 26 Jul 2020 17:41:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1424594062D for ; Sun, 26 Jul 2020 17:41:44 +0000 (UTC) Received: from localhost ([::1]:40800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzkec-0004Mg-BP for larch@yhetil.org; Sun, 26 Jul 2020 13:41:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzkdo-0004Lx-GI; Sun, 26 Jul 2020 13:40:52 -0400 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:40432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzkdm-0001Lv-PA; Sun, 26 Jul 2020 13:40:52 -0400 Received: by mail-qt1-x831.google.com with SMTP id s16so10577967qtn.7; Sun, 26 Jul 2020 10:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=p+a7ZPusYVRt85Dv4SeHxkP5a81LmZ9yOzmkBJ5XwJw=; b=ZE8x7iuEeRFnS9KncDitbEHH07cHmvxsLcLJVYbuNk2h2g0YK1a1+aszBHtbz1xifm +iP3z2ocZ6JSXU0aKAZYRD0ktgrwcqniMuYGzHxGCxygdFNgcmrQZZfdTgPNqmmOS3P3 9e5u1JZH4SWh9gGSdhNyFwc+dDcd2lRGEjFzbI2k2OPGjh1Ed8DqhDO5LH37NqkEmg56 PdlgSe6Mx4cwns2uE7Zh9OjurxoIhcdLPNIYf3Xe8yT/eEsRdUg66pq1+mWEEll3waOI eUstbq6yFq2dXSPg5d8sTo1cwuw8W/+bJOebAK9JWttZleNBnJvAJYeSTIQc5uoWx14U OBQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=p+a7ZPusYVRt85Dv4SeHxkP5a81LmZ9yOzmkBJ5XwJw=; b=hV5+9BjiYaQQIxfdchQWFGMmiJGjrJs4zgNp93jdd4rlx9drFlXOiO17iylhqto/a7 3/2UuGDkdPTDfPxQLaMpRTDNZQ7qXO7PRcU2+m9TTIthsLY+Nbg9mquF4QTD3ZeRZ4Fq CU/oS9UejagPH6NFFg9NoAt51CZhliolPZNt8lLA8qvMGV8LNaLg7o0nV21x5pUuqO5/ yOJ6oLMK2HERu+V6Qw88ZQZztcwUf9kr0l0MtOdR//NuTDjBdtrW3Uey3OPyTYN+3c+l cgsvhM/aaHGzdhXnsinEP34B9yMSYaoa7DvOrpOK42Y/AOEEbNpMszJIK9Ydh4d+uplp olbQ== X-Gm-Message-State: AOAM533ZQzsaFUyErsoPPatGVOBXlcnHSUI4tSB+zfPhrjfLnnoYO5GC HB3MvavEZrV7nL4sJBfFQ0EakRRf X-Google-Smtp-Source: ABdhPJxBKs4WsIMwCqgd0ykG2tuE0jxTwThEErCAiXHfYJMQ8R0ZHqSOpWORtk4mCGWV8tWKGF//zQ== X-Received: by 2002:ac8:74c7:: with SMTP id j7mr3284928qtr.254.1595785248466; Sun, 26 Jul 2020 10:40:48 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id x5sm10367462qtp.76.2020.07.26.10.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 10:40:48 -0700 (PDT) References: User-agent: mu4e 1.5.5; emacs 28.0.50 From: No Wayman To: emacs-orgmode@gnu.org Cc: emacs-orgmode-request@gnu.org Subject: Re: [PATCH] org-capture: Update plist before finalizing (Leo Vivier) In-reply-to: Date: Sun, 26 Jul 2020 13:40:47 -0400 Message-ID: <87pn8iw4ww.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qt1-x831.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=ZE8x7iuE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: m6GZjoofagKs I needed a similar workaround in doct: https://github.com/progfolio/doct/blob/80d291e5f1cbdabd4eb7f88c917653c59d3f14be/doct.el#L589-L592 I restore `org-capture-plist' to the value of `org-capture-current-plist' after the `org-capture-before-finalize-hook' is run. As of: https://code.orgmode.org/bzg/org-mode/commit/3ba4f056d736c4ed4261ad3b234e0199edec6e8c `org-capture-current-plist' is available during all hooks except `org-capture-after-finalize-hook'. So `org-capture-plist' should be ignored in favor of `org-capture-current-plist' after the initialization of the capture process. I came to the same conclusion. Restoring `org-capture-plist' after finalizing a capture should not cause any harm.