emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: No Wayman <iarchivedmywholelife@gmail.com>
To: emacs-orgmode@gnu.org
Cc: emacs-orgmode-request@gnu.org
Subject: Re: [PATCH] org-capture: Update plist before finalizing (Leo Vivier)
Date: Sun, 26 Jul 2020 13:40:47 -0400	[thread overview]
Message-ID: <87pn8iw4ww.fsf@gmail.com> (raw)
In-Reply-To: <mailman.45.1595779211.26639.emacs-orgmode@gnu.org>


I needed a similar workaround in doct:

https://github.com/progfolio/doct/blob/80d291e5f1cbdabd4eb7f88c917653c59d3f14be/doct.el#L589-L592

I restore `org-capture-plist' to the value of 
`org-capture-current-plist' after the 
`org-capture-before-finalize-hook' is run.

As of: 
https://code.orgmode.org/bzg/org-mode/commit/3ba4f056d736c4ed4261ad3b234e0199edec6e8c
`org-capture-current-plist' is available during all hooks except 
`org-capture-after-finalize-hook'.
So `org-capture-plist' should be ignored in favor of 
`org-capture-current-plist' after the initialization of the 
capture process.
I came to the same conclusion. Restoring `org-capture-plist' after 
finalizing a capture should not cause any harm.


           reply	other threads:[~2020-07-26 17:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <mailman.45.1595779211.26639.emacs-orgmode@gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn8iw4ww.fsf@gmail.com \
    --to=iarchivedmywholelife@gmail.com \
    --cc=emacs-orgmode-request@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).