From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AAIPNbXLaV+eagAA0tVLHw (envelope-from ) for ; Tue, 22 Sep 2020 10:02:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0MryMLXLaV+dDAAAbx9fmQ (envelope-from ) for ; Tue, 22 Sep 2020 10:02:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA24A9406A5 for ; Tue, 22 Sep 2020 10:02:28 +0000 (UTC) Received: from localhost ([::1]:51584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKf7z-0000dc-6Z for larch@yhetil.org; Tue, 22 Sep 2020 06:02:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKf7F-0000c1-3Z for emacs-orgmode@gnu.org; Tue, 22 Sep 2020 06:01:43 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:40854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKf78-0002Z1-P5 for emacs-orgmode@gnu.org; Tue, 22 Sep 2020 06:01:40 -0400 Received: by mail-pg1-x52b.google.com with SMTP id k133so6771898pgc.7 for ; Tue, 22 Sep 2020 03:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=3qyQ8OeE1iflfHDPo5E/iRZvB6+5hm1CXHmSHHHG1LU=; b=i3e8WAK+7/dekAFu/8FScnq0fUvzVr2MotNJRzasCoajxo/i5LUIeua1oAYaoEFjyv M1KSSX9hFJ9roRZGvEE2JLBoy3EU8sdiEjlma22yfAUrCBvTHXXVgVvNdJrNeD0LbmCW pT4w9eJQUjhXj549zz4taJocnqdYuFz60IteUsI5g4wTv3ZuvdH/4khfvgmn/EppoYT1 pL00YcQZyv98y7zxb5IDag+cTY2Wm3xeUyUpxYr/WRttZWFkp0Y8q2g05FNLETW7XDyI sTp0GISpRrecWgcXV62cUFEytFnbR04t4zL+aTJKwMjNgxUHSXR5cKrZJQTGikLTVkPe ESMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=3qyQ8OeE1iflfHDPo5E/iRZvB6+5hm1CXHmSHHHG1LU=; b=ZFscGFjlL2++HkuoMsIJe49rN/tjGr3UsJY/qXFE4OE6DYiBy7j0OCK/2IeUusskkk grHFFTW6lxcESuWOGWEI0J5wb5D/DN2Wd47vsWQZvbYfWs4ModAmjVtXAE/Bxme5owo4 +FqvkcI4qE0vANE0ChM9zcXqMYa9dVbIAAa6ksx2rekxpvtrT+7uMUGK2r4qGc72J5Nv 6fNqdA3jF94TIICzinRcq3P32IHvUNMuzVSJe9a31DDcdtuM3+wk8J0Gf2xaTPhlEl6s 0Fkv2fn3JEg7RgIG4oFnFiszuyAdFrGEA5MsBgttZluKBjNj0iYpWR+Ght4nKdxKIUIC F6hA== X-Gm-Message-State: AOAM531y2CcR1pd19u49bbGNCIZEZ19wR05HMg0dty5Iqkwmto18DtHD 4URXoQfu0UMVAGqzPK5Cgwo= X-Google-Smtp-Source: ABdhPJwk3LanzYxWDGTSEfqUdYjhvHuPuwAY4WRu7oFZP5k/yVJVlcWvMDrUuCu/T2yG/wEr3fP9sg== X-Received: by 2002:aa7:9409:0:b029:142:2501:3989 with SMTP id x9-20020aa794090000b029014225013989mr3555142pfo.78.1600768892952; Tue, 22 Sep 2020 03:01:32 -0700 (PDT) Received: from localhost ([210.3.160.218]) by smtp.gmail.com with ESMTPSA id y29sm15846883pfq.207.2020.09.22.03.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 03:01:31 -0700 (PDT) From: Ihor Radchenko To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec , emacs-orgmode@gnu.org Subject: Re: [patch suggestion] Mitigating the poor Emacs performance on huge org files: Do not use overlays for PROPERTY and LOGBOOK drawers In-Reply-To: <87sgbaw58y.fsf@localhost> References: <87h7x9e5jo.fsf@localhost> <87pnbby49m.fsf@nicolasgoaziou.fr> <87tv0efvyd.fsf@localhost> <874kse1seu.fsf@localhost> <87r1vhqpja.fsf@nicolasgoaziou.fr> <87tv0d2nk7.fsf@localhost> <87o8qkhy3g.fsf@nicolasgoaziou.fr> <87sgfqu5av.fsf@localhost> <87sgfn6qpc.fsf@nicolasgoaziou.fr> <87367d4ydc.fsf@localhost> <87r1uuotw8.fsf@nicolasgoaziou.fr> <87mu5iq618.fsf@localhost> <87ftb9pqop.fsf@nicolasgoaziou.fr> <875zc2du63.fsf@localhost> <87wo4en8qk.fsf@nicolasgoaziou.fr> <87mu31adeu.fsf@localhost> <871rkcbx40.fsf@kyleam.com> <87mu301in8.fsf@localhost> <87lfh5vvrp.fsf@localhost> <87sgbc4qpl.fsf@gmail.com> <87sgbaw58y.fsf@localhost> Date: Tue, 22 Sep 2020 18:00:28 +0800 Message-ID: <87pn6ew2pv.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=yantar92@gmail.com; helo=mail-pg1-x52b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=i3e8WAK+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: +sWsSCTJaOo3 >> then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't >> get a stacktrace. I'm guessing this is because this error (which IIUC >> originates from org-back-to-heading in org.el) is a user-error; however, >> if I change the function to raise a "regular error", then everything >> compiles fine=E2=80=A6 =F0=9F=98=95 > > I suspect that you forgot to run =3Dmake clean=3D (to remove old untracked > .elc files). I was wrong. It was actually a problem with org-back-to-heading. Should be fixed now. Best, Ihor Ihor Radchenko writes: >> I get a conflict in org.el, on the hunk where org-reveal-location >> and org-show-context-detail are defined; since your patch just >> deletes them, I resolve this with: > > That's because the patch was against 0afef17e1. The new version of the > patch (same URL) is against aea1109ef now. > >> I've tried going to doc/, running=20 >> >> emacs -Q --eval '(setq vc-handled-backends nil org-startup-folded ni= l)' \ >> --eval '(add-to-list '"'"'load-path "../lisp")' \ >> --eval '(load "../mk/org-fixup.el")' >> >> then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't >> get a stacktrace. I'm guessing this is because this error (which IIUC >> originates from org-back-to-heading in org.el) is a user-error; however, >> if I change the function to raise a "regular error", then everything >> compiles fine=E2=80=A6 =F0=9F=98=95 > > I suspect that you forgot to run =3Dmake clean=3D (to remove old untracked > .elc files). > > Best, > Ihor > > K=C3=A9vin Le Gouguec writes: > >> Hi! >> >> Ihor Radchenko writes: >> >>> The current version of the patch (against master) is in >>> https://gist.github.com/yantar92/6447754415457927293acda43a7fcaef >> >> I'm probably missing something obvious, but when applying your patch on >> top of master[1], make fails when generating manuals: >> >>> emacs -Q -batch --eval '(setq vc-handled-backends nil org-startup-fold= ed nil)' \ >>> --eval '(add-to-list '"'"'load-path "../lisp")' \ >>> --eval '(load "../mk/org-fixup.el")' \ >>> --eval '(org-make-manuals)' >>> Loading /home/peniblec/Downloads/sources/emacs-meta/org-mode/mk/org-fix= up.el (source)... >>> Before first headline at position 760959 in buffer org-manual.org<2> >>> make[1]: *** [Makefile:31: org.texi] Error 255 >> >> I've tried going to doc/, running=20 >> >> emacs -Q --eval '(setq vc-handled-backends nil org-startup-folded ni= l)' \ >> --eval '(add-to-list '"'"'load-path "../lisp")' \ >> --eval '(load "../mk/org-fixup.el")' >> >> then M-x toggle-debug-on-error and M-: (org-make-manuals), but I can't >> get a stacktrace. I'm guessing this is because this error (which IIUC >> originates from org-back-to-heading in org.el) is a user-error; however, >> if I change the function to raise a "regular error", then everything >> compiles fine=E2=80=A6 =F0=9F=98=95 >> >> >> [1] git apply --3way, on top of commit b64ba64fe. >> >> I get a conflict in org.el, on the hunk where org-reveal-location >> and org-show-context-detail are defined; since your patch just >> deletes them, I resolve this with: >> >> git checkout --theirs -- lisp/org.el