From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: this nkk <thisnkk@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)]
Date: Tue, 06 Oct 2020 12:15:56 +0200 [thread overview]
Message-ID: <87pn5vu0bn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <86k0wiyalj.fsf@aa.i-did-not-set--mail-host-address--so-tickle-me> (this nkk's message of "Thu, 24 Sep 2020 17:16:24 -0700")
Hello,
this nkk <thisnkk@gmail.com> writes:
> when running org-id-find-id-in-file on an id and an unvisited file, the
> buffer it creates to visit file isn't
> closed after finding id.
>
> ** what should have happened
> I was expecting it to close the buffer if the
> file wasn't already visited by another buffer.
>
> Is this desired behavior?
It depends. If MARKERP is non-nil, you certainly don't want to close the
newly created buffer. Otherwise, it could be closed, indeed.
I patched master along these lines. Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-06 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 0:16 Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)] this nkk
2020-10-06 10:15 ` Nicolas Goaziou [this message]
2020-10-06 21:36 ` Samuel Wales
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn5vu0bn.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=thisnkk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).