From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SLexJvVbEGFUCwEAgWs5BA (envelope-from ) for ; Mon, 09 Aug 2021 00:34:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +LJBIvVbEGG0DQAA1q6Kng (envelope-from ) for ; Sun, 08 Aug 2021 22:34:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BCD4FCFEF for ; Mon, 9 Aug 2021 00:34:28 +0200 (CEST) Received: from localhost ([::1]:45542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCrND-0005nl-JS for larch@yhetil.org; Sun, 08 Aug 2021 18:34:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCrMn-0005nb-Pu for emacs-orgmode@gnu.org; Sun, 08 Aug 2021 18:34:02 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:41533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCrMl-000787-3V for emacs-orgmode@gnu.org; Sun, 08 Aug 2021 18:34:01 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1628462033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=loCOU1SbETsWFAnJR8qjKf5QxCNXNtmh7XyS6JzYRnU=; b=o9HOsccxW1ljdi0fYeWtJ5fKXiR73nZreteVlQwFk+3fsTWNw1yJnuWPFJzELie8h0Hwyx cUO0P2LP/IB8ywWUqgiqcRE/9i+etuGCFz7LxymSzgB1StsQHen5vCEEjX0tWIygpYPho1 OCEWg5TyT4fHRjlVGLphF8ph7xGVGwF7ll2hx86Rwkrj5D11zpODXCVdMxiajm6CsnZMcq K+5yabXflL7yNi1mG3jdzVDStUaCZY246NMF4G/Jz47ezhHzPL+GwDOhYPn78N0SD8Juph NFKIVyLD/FMuaBgOjswPz0JuOp03tpCK3emrZwuq05EvgpMRa8im7YYr/usfOg== From: Kyle Meyer To: Marco Wahl Subject: org-attach-sync uses directory-empty-p (new in Emacs 28) Date: Sun, 08 Aug 2021 18:33:51 -0400 Message-ID: <87pmun8t2o.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=kyle@kyleam.com; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628462069; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=loCOU1SbETsWFAnJR8qjKf5QxCNXNtmh7XyS6JzYRnU=; b=hx721EaBE7qVQgIvMMGNlh+oAjv9Y9LbYML5LIic/osMogLMDd4XzNZq6R9FCnwc699zSQ bT8gO2yFyhkAMqMmYZ5OHkStuZM71gAY5rgMrql0ggtsyeC8mHesFT3ewumrlTA5xvEaiZ HFUmdP4yW07mGan4SFcEcQJ4Vo6DBAavACunontTih4HHS1a4vL/IfR/TPIx3tSptWr0ee 9v3zhkgR7aNb7e55lCjxhO1kM65tesYfq1WX3Zj/PfV2eVHyIKYRWukDuxXJG87vbhio2L MODdas0jG3RgzdQYTikK6TTWZQ9LG1XBHcGXl4HzSnOhovY/qDNoJQCeOsPDaw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628462069; a=rsa-sha256; cv=none; b=qt7iWay5Ixp/GGCon2EEuDCqtBqnmSJEH14NUBLzbWFdsQOIFpFWDS3xMe5S1h53eKlZ0z d9DGs42xOv2g8dqg/ZdDkXYWQ7zPtXkGYsnDzqJ2/N84feLLjY3JWvkvvIxNT7yQErAXMj XlUFa3tF3MV4YMALQh0Pk+X2I3GqvIico6GEpO6PcRQQmsST7M0M5niGiNVCCEwq95O2cM /kR1XC8RJyUhcNXuwN2ewet2/F06y5gPvqMyovA/qB+6OHZwHEMAOSfkBoS4fauieO1KlV OATueb/p7pM/U/BGGWC2IuDH8LX9cs3SMFrPEczF90A+ueu5Ov3Z2iAbpVQYRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=o9HOsccx; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=o9HOsccx; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: BCD4FCFEF X-Spam-Score: -2.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: pwxJkpUCi5CY Hi Marco, In 61e083732 (org-attach: Possibly delete empty attach directory, 2021-07-09), you added a call to directory-empty-p. This function was introduced in Emacs's 0806075520 (Add directory-empty-p and new argument COUNT for directory-files-*, 2020-11-02) and hasn't yet made it into a release. Could you update org-attach-sync to avoid using directory-empty-p (e.g., by inlining it or by adding a compatibility alias)? Thanks.