From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sCZILHarZmEMwQAAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 11:48:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WOfoJ3arZmHTNgAAbx9fmQ (envelope-from ) for ; Wed, 13 Oct 2021 09:48:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FC521CB26 for ; Wed, 13 Oct 2021 11:48:38 +0200 (CEST) Received: from localhost ([::1]:41576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maasH-0005ce-6F for larch@yhetil.org; Wed, 13 Oct 2021 05:48:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maaoE-0002Op-2B for emacs-orgmode@gnu.org; Wed, 13 Oct 2021 05:44:26 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:39773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maaoC-0006XU-2Q for emacs-orgmode@gnu.org; Wed, 13 Oct 2021 05:44:25 -0400 Received: by mail-wr1-x434.google.com with SMTP id r18so6233369wrg.6 for ; Wed, 13 Oct 2021 02:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rrft3fKnYbO/QH+rXgD8konRstB05Gj3k9kdAgbYL8w=; b=IXTCjEhrV2RLhLqoMc2iiScCv/TzI8FzRPMVKgkSWJtYcvD3d1h3t5BSnGaNEAEG43 wiW3c8lQJmnVbtsghBihG3edHDtu1vcGQqqnm1IKb31ADQV+5fIH/WpgK/qOc1vaP66F 2f2CJYdOADydfwYQERlxwQZ3skcodT1Hnwe711wI9HKyIjuZlMU5QKRd48y6dLYS2oFT IDtl7udnOV6UACl2SbT2iPX1NsGMgklUAWxCa3x26LVQ6ROR4cM3/kg+ZQAvKtp9xLKj TdTJVG3Kb8O55rxXCXBXMiIVsb37U2PE9FnYQqaENAiZqahdzRKIZU5ysONZ47ZUck8M PXDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=rrft3fKnYbO/QH+rXgD8konRstB05Gj3k9kdAgbYL8w=; b=bVEb5FvW0i6uTVOQF8/zQk0ILdhQ3+azX+RAi2Qb7Z6rhJJYe+7gCOkgoTM2b4YJuw dKqhngoHjoWw/t4wzGceOxbXMYJs1/SPKTpB+2z+EhZD2OgKwgo6357z2afhk3z2Cj7T Njg723sw9BMoTDcRL11xmb90O83ltIbSNPq8Z2OZ4MBg66ZgEm2KbuyUlqlywmQII1aD ogIleiNzouaDV6txZBRItP2hYUsdJBglaAAmZq2PLAleO7ISMVlm53+Roqveb9QIiLj5 sReC6ddZSGbl0YvAUPaT6vSyz6yDmcAUBC8V65E5OmbdgDnk2BIMpi5cKEON0fMIrk1j f5uw== X-Gm-Message-State: AOAM533Nrm+g9QCTW4ynQP0jk/cvy2km1Pb8ZuQFV2y3frJQZA+Da/2S bbMxp/6B++8YA62wa2Yzk2M= X-Google-Smtp-Source: ABdhPJxE7Dwdl6OdeiUqkXNFcngIYJSH3WSQoc2Ygzow9x68/npZotu01BDN1WO+bfsK5spahD92fw== X-Received: by 2002:adf:a183:: with SMTP id u3mr38620525wru.330.1634118262414; Wed, 13 Oct 2021 02:44:22 -0700 (PDT) Received: from aspire-5942 (p200300d867468600c0790b8dc06e98ee.dip0.t-ipconnect.de. [2003:d8:6746:8600:c079:b8d:c06e:98ee]) by smtp.gmail.com with ESMTPSA id l13sm8143448wrn.79.2021.10.13.02.44.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Oct 2021 02:44:21 -0700 (PDT) From: Marco Wahl To: Ihor Radchenko Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Organization: Marco Wahl References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> <87czoaug5x.fsf@gmail.com> <87o87tso54.fsf@localhost> Date: Wed, 13 Oct 2021 11:44:20 +0200 In-Reply-To: <87o87tso54.fsf@localhost> (Ihor Radchenko's message of "Wed, 13 Oct 2021 09:35:03 +0800") Message-ID: <87pms9mf7v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=marcowahlsoft@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Nikulin , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634118518; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rrft3fKnYbO/QH+rXgD8konRstB05Gj3k9kdAgbYL8w=; b=YSOkqzVfVkJBOEaDNsdgM1BVW3psVGkb7TBQabJ9U++x2KCzQG2IOimIEaq2chW4yFeR6d D18YCby84XWeVuNvnZPOJHg22pIj0lPLaxWrvDpgXpcpDxaOI9BKt8FGFNBHTZ9W5kaYtM hfG131IZd7XEvI3rEhu97QQbwRD9z8OXfMGAZMOXS+jn7yL5jpWp0V7/VT6We4LKBbGwy/ wTPca2Ts2AR8b2lclNdLouyH6EDnNIxatAprQq8nVVU4kCTXCGO6rp1cOqFQYuYDrhx3lZ +wVI16f7O5Gol/iWbqlRATnovTPjvXPfuXZi6q4hdZQUbEKDi3sRkTK0q9G2nA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634118518; a=rsa-sha256; cv=none; b=LCiQuI9JsYr+8Os2LDbDMXzZ7EENpgdzJfpcxXTTB54/O0F3N7kIMYDTt/KL3UrReeACbz oHaEbxgU7RTSrFKcaXzPze6pTPW0s6SGE9MBgGw0CJtsIRtvxN23v7kfkmI3M91ChXSyYM 0osREfkyrv214SAQv8/h28YHlMvdvVh22WYQAnBwn/n/czvZrVwRhMZvdpLdsVGN8lk/HY fbsTlbM17DIxqsXcRWuct3s+b65v2U0bgpc1jzhmD1bx+KImJQaNMxeVcHce0uI0pSu5Rl ZsG71SRXWmo3215piuULgyeH0IVOmxW4Bk3ebNwtElxyzTjSMBRu5/eivVZZ5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IXTCjEhr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IXTCjEhr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 2FC521CB26 X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: ffuM5e5oEzzt Thanks Ihor! > Marco Wahl writes: > >> My feeling is that the "protection" is good intention but brings more >> harm than good. I think it's not a good idea to enforce a certain >> window setting. I guess the knowing user has an easier path to fine >> tune the org-goto user interface when there is less "protection". > > I fully agree. That was the motivation behind removing > dislpay-buffer-alist in 399481bad1. It is indeed not a good idea to > overwrite user customisations. They can be deliberate. For example, see > https://orgmode.org/list/87h7ij12t8.fsf@localhost > > Max Nikulin writes: >> However current version of macro does not protect against >> >> (setq display-buffer-base-action >> '((display-buffer-reuse-window display-buffer-pop-up-frame) >> (reusable-frames . 0))) >> >> The example is taken from (info "(elisp) Choosing Window Options"). I >> have no idea if such customization can be considered as shooting a foot. > > display-buffer-base-action, if customised by user, can later be > fine-tuned using display-buffer-alist. If necessary, the user can easily > add org-goto popup as an exception. At least, it is my understanding > from reading docs. > > However, pop-up-frames and pop-up-windows are different beasts. They > cannot be fine-tuned by the user to not affect org-goto. AFAIK, the > only way for the user to overcome the problem would be advicing > org-goto. > >> Summary: The org-goto interface today is somewhat broken. I vote for >> taking the occasion and kicking out the macro org-no-popups entirely. >> This way the org-goto interface is functional AFAICS. If problems occur >> on that path we'll take care and action. >> >> Do you agree? > > My second version of the patch also fixes org-goto interface :) Indeed, thanks. > On the other hand, kicking org-no-popups macro completely may be an > option. pop-up-windows and pop-up-frames are obsolete and should not be > used anymore. > > Also, a compromise could be changing org-no-popups to just > (let (pop-up-frames) ...) > > WDYT? Clearly I'm for kicking out org-no-popups completely. Many details have been mentioned already. The big argument for that change for me is that the code gets simpler. But that's just me. All the other fixes may have advantages too. In the first place I want back a usable org-goto interface. I'd like to leave it to you to commit a fix. Best regards, -- Marco