From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wGM/H3UhMGNlAAAAbAwnHQ (envelope-from ) for ; Sun, 25 Sep 2022 11:37:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AHItH3UhMGMhQgAAauVa8A (envelope-from ) for ; Sun, 25 Sep 2022 11:37:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE1DB2A517 for ; Sun, 25 Sep 2022 11:37:56 +0200 (CEST) Received: from localhost ([::1]:35560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocO5D-0001dv-MC for larch@yhetil.org; Sun, 25 Sep 2022 05:37:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocO4l-0001dn-LP for emacs-orgmode@gnu.org; Sun, 25 Sep 2022 05:37:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocO4k-00071e-Dc; Sun, 25 Sep 2022 05:37:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Du3v9/4pltaSKj9mR04V0rC67MZlDJ37tsxhBAp17BM=; b=eI/Bvhm1Ch2gdICSSs7r 0r1Zn4vAHaz8fHlD8I92VBWCF82bGcr0oYCldYBrQpnNa7DBkMSzbgMqbgwJksQwRZBP5b5RE2bfC ohjMwcUQsUBeAgv9lqBaPdfV1jVNV3JQ1Lu8xMoPw7h6SUoatJ3G4eTqUNTZdAAHmE4uvxnTHXWry wlxkNwq1840QwCvaRcLD0xAPr89nHWdAnCdci4Ao9SIDSbTIae/K5tBvN7eomGHycUj10gGIJY8Ua Bgs8+wxc0G2OwW/JnqBP/jhsrcg08eu2q9uIf+5GXXfS4oGeMbASRY6LinwMLwASo6lpXV/VxUDII dxQHrgWJDfafTw==; Received: from 96.52.140.77.rev.sfr.net ([77.140.52.96]:56288 helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocO4j-0004X9-TH; Sun, 25 Sep 2022 05:37:26 -0400 Received: by hal (Postfix, from userid 1000) id 1FB3B1E0409; Sun, 25 Sep 2022 11:37:23 +0200 (CEST) From: Bastien To: Ihor Radchenko Cc: Stefan Monnier , emacs-orgmode@gnu.org Subject: Re: org-assert-version considered harmful In-Reply-To: <874jww16w3.fsf@localhost> (Ihor Radchenko's message of "Sun, 25 Sep 2022 11:15:40 +0800") Organization: GNU References: <875yhsujkq.fsf@localhost> <87h71ct10n.fsf@localhost> <87tu5bbajh.fsf@localhost> <87r10ey8ov.fsf@localhost> <87o7v4dvon.fsf@gnu.org> <874jww16w3.fsf@localhost> Date: Sun, 25 Sep 2022 11:37:23 +0200 Message-ID: <87pmfjpzfw.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664098677; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Du3v9/4pltaSKj9mR04V0rC67MZlDJ37tsxhBAp17BM=; b=KxhRyB9LJrpp4ijOy9ezxRkKWIl/yXwUggUkxG7VzSzLZJPQ2mrIgTba5sKezJvFljh6sk jlcXHdw1sTfaTVH1ijvGh2RhLYdHog5Gj4yyNuich1LIr/I/hlg63ue7RWmqxaIL2V+eR4 OjnsatbQ+SZ8ukXT9slrtZphUucs5LdhOX1No4gH3J8iZzrDWEUY0ZUTmVta/zkd4BX1o8 zADV2ncDb7oBDi6TKaZs/0yN74YJh4OkrIIrSir4DDqUIT3Jauy3znUXtBAzdcLZ1vIkT9 DkP6S4xkSoTBT8gRnYTPpU7LzitvhaOPfJdyBP0Y695+/an07Mo6OWB9zSWIKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664098677; a=rsa-sha256; cv=none; b=FD8rO4y+ru79XS5WnIwfXOaIXAelulSVZAmCs6D0jTInuwGHpXKXnADiowS9MwDBLuXbPJ ypv85yF8xaKEBqq3EhOr1OAPVkHgYf2jmfuyj00XGubkRic70RbhiIeskfDpWrdeYPgJ5p hnllisG7ExikfpST2h3dV1cjrHVufNvb4qbDQNj1+oE6EEMUc4SrEDj/zMDH6bKgHV0zb+ E6zaPlpuWAIyHvbFAVSGQro8D7CojCM3UG2owirOggFcSO07/yvzYlSeI99defbBnrhU5k RTeByHcVBuxYfoTOrEsEd40O3mo78qYn3vF0ZQAzNU1v5gskzT2qrJRVaQRDjw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b="eI/Bvhm1"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b="eI/Bvhm1"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DE1DB2A517 X-Spam-Score: -3.55 X-Migadu-Scanner: scn1.migadu.com X-TUID: k7/nAI79ip+P Ihor Radchenko writes: > Currently, main and bugfix branches both have (org-version) ; => "9.5.5" > As a result, the assertion will not catch the important case when users > mix Org version installed via package.el and Org version installed from > git. > > Should we use the next planned release version number on main branch as > a convention? I'd rather use the value set in the ";; Version:" header. It is "9.5.5" in the bugfix branch and "9.6-dev" on the main branch. I'm not even sure we should keep `org-git-version' at all: if we need to distinguish between pre-release states, it seems easy enough to set the header as 9.6rc1, 9.6rc2, etc. WDYT? PS: I have a vague memory that Stefan suggested to look at how things are done on bbdb.el: https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/lisp/bbdb.el?h=externals/bbdb#n4750 If we can remove the complex Make machinery we have right now, I'd be very happy. One reason for this machinery was to avoid merge conflict (thanks to getting rid of the Version: header), but we do have these conflicts (now that the header is back) and they are easy to solve. -- Bastien