From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eP0oEfi8O2OmQgEAbAwnHQ (envelope-from ) for ; Tue, 04 Oct 2022 06:56:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KD1mEfi8O2P8OgAA9RJhRA (envelope-from ) for ; Tue, 04 Oct 2022 06:56:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFC993B04B for ; Tue, 4 Oct 2022 06:56:23 +0200 (CEST) Received: from localhost ([::1]:45704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofZyg-0003Ui-82 for larch@yhetil.org; Tue, 04 Oct 2022 00:56:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofZxs-0003UI-An for emacs-orgmode@gnu.org; Tue, 04 Oct 2022 00:55:33 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:38526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofZxp-0004Ri-UI; Tue, 04 Oct 2022 00:55:31 -0400 Received: by mail-pl1-x62b.google.com with SMTP id x1so11708204plv.5; Mon, 03 Oct 2022 21:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=2Nc3PxD2kQ9gseDJBsbTRxu90oFsNetPWP4tLS7XInM=; b=YpYFj2DrPNf7m5h/jJZ87Fom6JJLNl0GEt+WgEY1coHlMYXUFOibn/1YjjCLO+blYg WT5Q227e25CvWHC2TWj/HT+rzHeUlwemEutNbNFLmHWR3tZlZP+KWprHGAl0mV2aBPFo 8UW+9T2dVuC87z1pEkL2nxhgbWu8FL8xZyPAVcGEIDr85Bl32iM/d3iktjb/LeQ5cGVq iWjn2CsC1ml49fBBdYZ2RB+Dr1bbjM7731WMdgN0dmpeuN56FiZzO3n6fpQi4DgqPlfI p9uU+nj+x0sUjvCjzvJN7by2PlkklAO+1nFTNyEAFkLGrCcva7H5LcYzMnorSWDRRkb+ DOew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=2Nc3PxD2kQ9gseDJBsbTRxu90oFsNetPWP4tLS7XInM=; b=2rseuGhSMnRl5zo5OdvtD9m78fecXyNPO9ZBV/jBy+syxBUxz5DxSJJWEEMyssy5Vb S2FgqGjCDdQHlzAcIiwTFXrjxtJ/n9wiQi6+Jl0r9zfdRRbofLgcV4kLpbwZZfg+pbON dDOJodkQFInT0cS/PHe9xYsWO7TPJCSxUM+vWlWsVAUZjWVlFV3zil/km7AXVls5TufX Z2IGdW2ABSDxo1RhRsQkn9JsEBpmlzhC/d+Xk+FSb/mJkuSQtyTt4Ri/Qni7KUrsU7q8 trnRyShAa1s8P4JfuseG4EmB6eQZF9y1w8db4xDPoZ+qZDGVUNxqu9ZIxliI2KlXFSkI NMzA== X-Gm-Message-State: ACrzQf3JnDFEcU8bwlI6oya4XUNlbn8NKPZ6M1YpvKG8zsyTbLL+id40 hnUMlvFhg1/VEJL2Fj6dlGE= X-Google-Smtp-Source: AMsMyM5+qmOp7vq0sJuimMRqTUNJENs01ZR9HWOJatBt/gvEbGNTRLTaPcTLyPijRm/drtA5+WrCkQ== X-Received: by 2002:a17:90b:350d:b0:202:ff91:a0bd with SMTP id ls13-20020a17090b350d00b00202ff91a0bdmr15860189pjb.46.1664859327252; Mon, 03 Oct 2022 21:55:27 -0700 (PDT) Received: from localhost ([1.83.154.214]) by smtp.gmail.com with ESMTPSA id v20-20020a170902f0d400b00176cdd7e4c6sm8064120pla.50.2022.10.03.21.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 21:55:26 -0700 (PDT) From: Ihor Radchenko To: Christian =?utf-8?Q?K=C3=B6stlin?= , Bastien Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el In-Reply-To: References: <8735c61y5o.fsf@localhost> <8735c5zhth.fsf@localhost> <87h70lw1k4.fsf@localhost> Date: Tue, 04 Oct 2022 12:56:19 +0800 Message-ID: <87pmf8uqz0.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664859383; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=2Nc3PxD2kQ9gseDJBsbTRxu90oFsNetPWP4tLS7XInM=; b=Xlkoxsx9zqqqKAW8eR17BKkTaX+v9IGr6GhjmiRg07bEYXj1HeUOLWiXOpxcSwkyCWFUsG zs3jxPqcb5VvXSEt6Q9dvOk/ulGPussJWX+JYXbIvAfXcK6ZfPEmAnFGZT3oX46hxOicIU 6UJT9DgGlt/MABEqJ+ecOItGQtKLmtUwjv8G1idCFJRI4qjDUVAqMYZUsPLfu/iRlJQPvv zJGHhgGJIS3lR3/jKV7Cjc4tJIVtc79YvlKOKp/xWjT0mE0Bu0xzx8maXFcnW9fAa1ZDd3 yOnsYSSQwfxW3rMSqZmyoztmbUtWnxSgsHJqU2SsGzs3+gnhAc0harNFDC1VBQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664859383; a=rsa-sha256; cv=none; b=RueeDb/d9JjH2SJoDyFN2R0EWpu8fGYuerXfsET9oHei5WxGYNFLa8Je5pAvxs0+J3WgiV gVHBFTIm1LFp92ZRUmAtnXjF3ebmxznMG2ssDXdyoW9nZDzLtTDGj/g29HlJmeOfd/aePK UHJVIxNzPBp2PHJkL8gcatHO9XsSZuwATSNfcBUiSHgiW7gpYbajnt0M1LA2hPQbqOn5o2 fldXEISJelzJAohSmq/NJNOwvwymPo4kZTZ7tGGsN1glWA/dUHH9HGoYufm3u9VDbUZKx8 JHi73eH/6aNiCWCIbLwSPmdfB1ktjeLdQvQ7TfNdo2EyqcpTmn2f3ZHj37di2g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YpYFj2Dr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.86 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YpYFj2Dr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BFC993B04B X-Spam-Score: -1.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: NueypZA8Xp5y Christian K=C3=B6stlin writes: >> If the programming language is using its own package manager, is it any >> different? Or do you refer to something else? >> > Most of the packages that a programming language like rust/crates, > ruby/rubygems > or dlang/dub-packages provide will probably never make it into the package > management system of the operating system. Also the programming language > package management usually has finer grained dependency management. > But it's just a theoretical question as no other ob-* integration > integrates a package > manager at the momen. If we do anything about such integration, we should not enable such testing automatically. What we certainly do not want is unsuspecting user running make test and getting some packages installed into his/her computer. However, the side effects requiring installing certain packages to the OS might be shielded behind Makefile customization that will be set to non-nil in CI tests. Of course, such customization should be documented in testing/README. >>> Throwing the 'missing-test-dependency has exactly same result, but also >> >> allows making our test suite indicate such issues simply by altering >> >> the 'missing-test-dependency catch code. That's why prefer >> >> 'missing-test-dependency approach. >> >> >> > Nice ... I just tested the aforementioned `(ert--skip-unless >> > (executable-find "dub")` >> > which also works nicely. I could post another patch that updates the >> whole >> > test-ob-C.el with one of those strategies. >> I am confused. Why do you need to use internal ert function? >> > I just tried what was proposed in one of the other emails ... I do not blame you. Do not take it for granted that every Org contributor, maintainer, or mailing list dweller is always right. In this particular case, I disagree with Max and I tried to put arguments why I disagree. If you think that I am wrong, you can refute my arguments. >> Note that we only have skip-unless feature in >> ob-shell/remote-with-stdin-or-cmdline, which is probably just an >> incident. >> >> Most of the test files use (signal 'missing-test-dependency ...) >> For example, at the very top of test-ob-C.el: >> >> (unless (featurep 'ob-C) >> (signal 'missing-test-dependency "Support for C code blocks")) >> >> We even have a dedicated function to test if executable exists: >> `org-test-for-executable': >> >> (org-test-for-executable "awk") >> (unless (featurep 'ob-awk) >> (signal 'missing-test-dependency "Support for Awk code blocks")) >> > yes .. the difference is, that with org-test-for-executable i get a faili= ng > test (same for `signal 'missing-test-dependency`) > with the ert function one gets a skipped test. I guess you tried to throw 'missing-test-dependency _inside_ the test. AFAIK, 'missing-test-dependency is caught when test-*.el file is being loaded, not when the ERT tests are being executed. See `org-test-load'. I think you can create a separate file like test-ob-D.el and run (org-test-for-executable ...) at the top-level there. > There is only one most important policy - if we recommend anything >> publicly, it must be Free software. The detailed rules are covered by >> https://www.gnu.org/prep/maintain/maintain.html > > yes ... still i am now lawyer enough to e.g. judge if gitlab/github is > according > to that. We generally avoid GitHub because of some of their practices (see https://www.fsf.org/search?SearchableText=3Dgithub). However, FSF policy is of a secondary importance here. WRT CI tooling, we just prefer something Org maintainers do use. Bastien, the chief maintainer, prefers Sourcehut. Since he maintains the Org infrastructure, we should also prefer Sourcehut, unless there are strong reasons to use other service. (Do not hesitate to name those reasons, if you know any) --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at