From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cF+xH/cmvmRdNwEASxT56A (envelope-from ) for ; Mon, 24 Jul 2023 09:23:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2DrXH/cmvmQ7bwEA9RJhRA (envelope-from ) for ; Mon, 24 Jul 2023 09:23:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 37FA368218 for ; Mon, 24 Jul 2023 09:23:35 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OtKoX2ms; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690183415; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SYqS7guofEEcKJn/rd4TQg3Xi5tVH9nzw7qtd18xaq8=; b=ddHtmuxMA53CQa3mnnJc/tYr0r1hYt6jSvLf9+aMj3DtW8F1CVviCL1dRFWiDNzAinVyV2 ox4B5hVwUHGfEk4pWhEndcmYbpNE4KeCOeR8rJ+o/TWV0KMNdQDa9oNMNLlFsQjfj5YKsK MggaVVUNVDbzG2eyaGcyRPVxdP7L9oZzUlLMcd887KKVLqPwZCGzHIjDUp11DHRW/sBts/ 2A7eQ1wmgeGK6W0aV+kSZZeC4kgKwq9TDoAFHiDuJg26xi0OSWOvfg4gC67Nfai6zmPRdp T0o1//LBsRvkKmtKl6AknJZ6Ub4xtTqfe0AqNv7TUGrEzMTAMlz/pKZhkVl9Xw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=OtKoX2ms; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690183415; a=rsa-sha256; cv=none; b=ZFb7zFRqAOWKezn5HkbjdFvOf+Wabd+J9WLnilxr7pGAqyUgsMclzxzQP8vd5yvYhIU9UM InY5FuKIzV8jOducepUxoTOcvjGnydok6/bvSFu1LFP+PqKGf8ZzyLd2rkZFdttTDh5rQ4 onxOPpN085LZ2YQ19E+aqzaXAZIhPJ+cBKY/7HQLv2LlIPOCtV78yuBZ+B+p5+kHUv2SjJ DZyHtxrdmvDTPgeSmtOyiIntUq8TuKgQ/SVg/WqbsZBSPDOLsfop0zf7trzTI3q649MYCL Hc6IW05C/Uk48oFp9YtgwtzXgOlaPmYGmB7SIxkD7tZfSLA9mKMx87wPjpO8Gw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNpuR-0007d0-Rz; Mon, 24 Jul 2023 03:23:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNpuP-0007aW-RK for emacs-orgmode@gnu.org; Mon, 24 Jul 2023 03:23:09 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNpuM-00057i-8s for emacs-orgmode@gnu.org; Mon, 24 Jul 2023 03:23:08 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A3EB5240104 for ; Mon, 24 Jul 2023 09:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690183383; bh=wommElsbrCycSsbh6mcgveO1GOAZoGIThGpX3mpy0E4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=OtKoX2mssSciXlUhCGGc+4lLtG2Ism6nFMh6f0TKrVEpH6m7qn4r0sMlIxO/Q7JQu j+T84jFDj4bHiLme/sMpyLr+ARpFwFiOyuVJx9Ef6ipBys4oaPMK/uo8dIlwIWdJRq pG4bEBnQWRd/MtlfMpcNr1kVuScXeznDuHnFkWzOeYQgg0qsMRPMefU9wJk24GdwW1 P9wTl+COBh2LS4/56e8nl7bc8h+ahkMW+ZsDA+B0E17SQQQksc9oi+Bv0fC7giEJm/ 9CtorxrnWeX/NEWrt8a8i3gSD6Z6uYA7dzWPLrAKiYJOfBcdQLGZQY9WxCvRJOtWMH Oh5FCvBwxeQxg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R8WpZ6dYXz6txc; Mon, 24 Jul 2023 09:23:02 +0200 (CEST) From: Ihor Radchenko To: Gavin Downard Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-table.el: Allow named columns on lhs In-Reply-To: <87mszmgf8r.fsf@runbox.com> References: <877cqwbpa2.fsf@runbox.com> <87bkg3hga5.fsf@runbox.com> <87jzurrujq.fsf@localhost> <87mszmgf8r.fsf@runbox.com> Date: Mon, 24 Jul 2023 07:23:16 +0000 Message-ID: <87pm4h3h97.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -7.35 X-Migadu-Queue-Id: 37FA368218 X-Migadu-Spam-Score: -7.35 X-Migadu-Scanner: mx0.migadu.com X-TUID: 6grASx8A62xy Gavin Downard writes: > Ihor Radchenko writes: >> Do we have any tests covering this part of the code? > > Not that I know of. I can add a test case for this specific instance, > but I'm not sure if I should add more comprehensive tests in this patch. > What do you think? I'd prefer to see tests for the aspects of org-table that are modified by the patch (if there are no tests available). org-table is an old, not very readable code. So, we should better ensure test coverage to avoid breakage. Eyeballing the code is not very reliable in this case. >> In Emacs 26, we will need (require 'subr-x), but otherwise it is not a >> problem to use `if-let'. > > Oh, I didn't realize that. Sorry about that. Nothing to sorry about. You do not even need to do anything. org-compat is already loaded by org-table and org-compat loads subr-x. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at