From: Ihor Radchenko <yantar92@posteo.net>
To: Gavin Downard <gavin.downard@runbox.com>
Cc: Max Nikulin <manikulin@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org-table.el: Allow named columns on lhs
Date: Mon, 24 Jul 2023 07:23:16 +0000 [thread overview]
Message-ID: <87pm4h3h97.fsf@localhost> (raw)
In-Reply-To: <87mszmgf8r.fsf@runbox.com>
Gavin Downard <gavin.downard@runbox.com> writes:
> Ihor Radchenko <yantar92@posteo.net> writes:
>> Do we have any tests covering this part of the code?
>
> Not that I know of. I can add a test case for this specific instance,
> but I'm not sure if I should add more comprehensive tests in this patch.
> What do you think?
I'd prefer to see tests for the aspects of org-table that are modified
by the patch (if there are no tests available).
org-table is an old, not very readable code. So, we should better ensure
test coverage to avoid breakage. Eyeballing the code is not very
reliable in this case.
>> In Emacs 26, we will need (require 'subr-x), but otherwise it is not a
>> problem to use `if-let'.
>
> Oh, I didn't realize that. Sorry about that.
Nothing to sorry about. You do not even need to do anything.
org-compat is already loaded by org-table and org-compat loads subr-x.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-24 7:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 2:36 [PATCH] lisp/org-table.el: Allow named columns on lhs Gavin Downard
2023-07-19 7:44 ` Ihor Radchenko
2023-07-21 15:15 ` Max Nikulin
2023-07-21 18:33 ` Gavin Downard
2023-07-22 2:12 ` Max Nikulin
2023-07-22 7:25 ` Ihor Radchenko
2023-07-22 13:16 ` Max Nikulin
2023-07-22 13:25 ` Ihor Radchenko
2023-07-22 12:45 ` Max Nikulin
2023-07-22 18:21 ` Gavin Downard
2023-07-23 6:50 ` Ihor Radchenko
2023-07-24 3:25 ` Gavin Downard
2023-07-24 7:23 ` Ihor Radchenko [this message]
2023-07-24 15:17 ` Max Nikulin
2023-07-24 20:29 ` Gavin Downard
2023-07-25 15:01 ` Max Nikulin
2023-07-26 21:50 ` Gavin Downard
2023-07-27 7:36 ` Ihor Radchenko
2023-08-29 9:58 ` Ihor Radchenko
2023-08-31 14:19 ` Gavin Downard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm4h3h97.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=gavin.downard@runbox.com \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).