From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aJSGGOgtMmVbDAAA9RJhRA:P1 (envelope-from ) for ; Fri, 20 Oct 2023 09:36:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aJSGGOgtMmVbDAAA9RJhRA (envelope-from ) for ; Fri, 20 Oct 2023 09:36:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 693CE5C09D for ; Fri, 20 Oct 2023 09:36:07 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=azcuBdI6; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697787367; a=rsa-sha256; cv=none; b=CkGVSJeWwfTJrkJSiKoKH531q2BBJwun+LPmWdN+T3xgnESIl9/oQD5xaNMzvoC7IKSIP8 OEtATuk2FA+5PNrdsgRRbKmVpESE0g7uzeGnhmtB89qjoLheGrIIwf+Te4oCGjhRfRi2SV E25IpRh4usRfeP4Ay9190ylhjgn8onI6/bBrTuFO4S6OHO8/nCR2hzOqTI63nG7A7WhGiQ SVunyJw9WmfWjge7WyxamFpmQiiAVMEa6O6bsuq8aKgxA9xFCuYqqM4Lpq8PJIV8gNSYnQ sZjwoXFXTeYJ2paGOjICdi8eBN4oegnHxhodwgJ4BFjWztpLY/tQgsaHMkhyew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=azcuBdI6; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697787367; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qfwWOCKfJh6wIaxLdD9Ml/0D+3ykkDUNVp+wlyKqpA0=; b=b8UmGibcyItWyoy8WAR62iBNVVfPtZCW81V+RYC0d5h7/mShk4dpWL42a9NPD0SjWPjvpm l5gfO5/F4TQ+pJpIMUO6jkxwS1sRJw43m9tH3WA+ObVDssuI78gWKrdk+pUmQzhvimjdks TEBnkofJJ4PxH64UrovbAIS9yS8Wh+mljgkH0JHD09u2wHZw18HsntzlkTL5r7HHPPIraE /LRW9YWpaUHVWartXLwOzaTD0huq2Zh8quSuHW3tgId+UlLWrqUtfuYwzCyvFU5gLPMnRD j6OeIckCLjequ2Eq36+jAd/SDEAKZ1pkFDz00q3ip20s0K3Mr5b352fQAoHkbw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtk2W-0005Cl-Dr; Fri, 20 Oct 2023 03:35:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtk2T-0005AU-Mb for emacs-orgmode@gnu.org; Fri, 20 Oct 2023 03:35:22 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtk2R-0000zD-OM for emacs-orgmode@gnu.org; Fri, 20 Oct 2023 03:35:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B0E5B240105 for ; Fri, 20 Oct 2023 09:35:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1697787316; bh=+/gpwzHZC+MNrFyOAUY8Zb7BITtp7PDcPlceobR+H8M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=azcuBdI69MThyssCeBxwYFKt8oFTugxTNL5G9j+ojyz5e+RXMZ1nuk4W/hhf4++sR q4BhMsRtRMRbW86hzv/eKuOtBZ+ik6JzaHd3rHG1rscPutV9YQrncmS1FzDpoJrcKM 0w7cq7SHz9aDygzdF8alnKXcmhdmxUta10Lnl+5sSYP5l3nZ0ca8t7nE/YH6Z6c56Y KIHj/+cji8MeUY2NjxXpKG9zwzCU2uVnIIOQ5p35IJLB050iTNdGKoZcF+2Rn7PwNh gqi/c1drKSQUxYK86I635kzjzRlG1eKSM9c4wkuiB/nzhKbELPXitbFbqgx4RA2/fE Imz+5gBPNblDg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SBbw41srKz6tsB; Fri, 20 Oct 2023 09:35:16 +0200 (CEST) From: Ihor Radchenko To: Vladimir Nikishkin Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-contrib: org-eldoc has an autload, but is incompatible with modern emacs. [9.6.8 (release_9.6.8-3-g21171d @ /usr/share/emacs/30.0.50/lisp/org/)] In-Reply-To: <871qdq54ol.fsf@laptop.lockywolf.net> References: <871qdq54ol.fsf@laptop.lockywolf.net> Date: Fri, 20 Oct 2023 07:37:00 +0000 Message-ID: <87pm19d9sz.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -6.36 X-Spam-Score: -6.36 X-Migadu-Queue-Id: 693CE5C09D X-TUID: cwl4T+prCt0G Vladimir Nikishkin writes: > org-contrib has the following lines 206 and 207 in org-eldoc: > #+begin_src elisp > ;;;###autoload > (add-hook 'org-mode-hook #'org-eldoc-load) > #+end_src > > which set up that hook automatically when the package org-contrib is > installed. > > that hook is, seemingly, incompatible with the recent org-element, May you elaborate about incompatibility? > ... and in general it seems dubious to automatically add features from a > deprecated repo. This repo not deprecated, but rather not much maintained. > Could those lines be removed? If someone is interested in > patching/using/maintaining that code, he can probably try to refactor it > in a better way. > > (In any case, it is probably better to add such hooks in the :hook > clause of use-package.) That would constitute incompatible change for the existing users. Although, autoload may cause org-eldoc to be loaded for users of org-contrib, who are not interested in org-eldoc. What we might do as a compromise is removing the autoload cookie only and leaving the (add-hook ...) to be executed upon (require 'org-eldoc). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at