From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kD4TMgvjfmbemAAAe85BDQ:P1 (envelope-from ) for ; Fri, 28 Jun 2024 16:21:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id kD4TMgvjfmbemAAAe85BDQ (envelope-from ) for ; Fri, 28 Jun 2024 18:21:31 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=stebalien.com header.s=fm1 header.b="g XNMVmp"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=NBycSbPL; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=stebalien.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719591691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=R7YteomLavkvgPZFn4vwtVDGoX+e+v2Ix/lMkJ3w2jY=; b=YGDpM5f0PdIV/aYiUFZT3Lqx12JqhUS64U0HETbo0u8nayuycWE0pxVdiKRCga1KXUJiqv Nc87BaxWOhkljlfYQs/W+A3Gfqner1V86EyMeZ0l4v5mrqnqWBV+1e/ro0nhcf6h2n3ybO Z1+stTNk3ouCdHWfLdNrCGWv9pqKJ9AHWS3LnUocGsZ15/5z6ztIXvnb8zKvc5q7l3n6XS hJCcTgziLFCUAzbthh82ZYl8TnBl6mYLXPcLNgj1JsAo3VFKq4ZI0QNuugalYPmUEkTOmp BgORUU58XdNCji0VAxhb3vKumZ9/Xa8q59TC02hqQVY8CSB2MPtWWB/hsgZakQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=stebalien.com header.s=fm1 header.b="g XNMVmp"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=NBycSbPL; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=stebalien.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719591691; a=rsa-sha256; cv=none; b=mXimrVdRSntefdIUz864mc0vEm/naIjCzPChHZ+iwP/SrVQ18GjY/Qs8DTuI2LpEbaQgg9 PAWFz3L8cQpFf2klVECQHbCt2Odad1SaTIxZB2bf/t12CvnUtjz/lKVaeZEXtI29MxPB6i 6WvKub7USMJly3cInnfRsvSdTKnVZOoov438YmqJ7WMc8iQSaSantwsX9RT2iSz9cfZ/Vq +AqjdgGq0imd7Oe9DzFgL8CEAYmEn8hQ13NLygeIv3qK6I6O6nYjIHGWql1bxyQSX+HHNg fa20puNppmpLgfvwbLmocgID9mPy2vl4ARPGs7ayVYLYQBCeR1a8OqG633UqZw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B6B603D405 for ; Fri, 28 Jun 2024 18:21:31 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNEL5-0007pA-4t; Fri, 28 Jun 2024 12:20:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNEL3-0007ls-KZ for emacs-orgmode@gnu.org; Fri, 28 Jun 2024 12:20:41 -0400 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNEL1-0004lL-N9; Fri, 28 Jun 2024 12:20:41 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id 72DCC1380290; Fri, 28 Jun 2024 12:20:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 28 Jun 2024 12:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1719591638; x= 1719678038; bh=R7YteomLavkvgPZFn4vwtVDGoX+e+v2Ix/lMkJ3w2jY=; b=g XNMVmpjtY1yIMn2y/4tULWxDAQX1WRaIiQBpufK6fsgKcBWVFFGERQRo8kO0hEZ4 6tTIbmLRzHmZZfJZqKvmGTXr9txPzagkkMGzwLwC8QeW2YRMbJWVjOzPwQNbdh0t N3cqJfirlHhaZHVbNnqDakvHE1Wdw+Ux+XgNI6T6Vc70Sbd5CSV/Djsojdv7O+vt sosxIhP/fIcHguJh+g/wpJ3d7LjE3p3VC3pAdQaBwQLviK5z+xiNkxpmNCKxHuYN 4AZzcTv07ooE8jYmQhFTE1d60nqT0Cl5Z2VPcUy8BBH2kph7epI30Vxfjscwa9Hr q7W3n7NT9UB2O/Cseb9fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719591638; x=1719678038; bh=R7YteomLavkvgPZFn4vwtVDGoX+e +v2Ix/lMkJ3w2jY=; b=NBycSbPLtmLPDtW96RnrHan9ZNSGyw2/Og4gWiq2IhGi jSMIdqO7TjLMnq8Wj8hjtP2CWYg7vX9JKmh6JAhgqo20mS64rMll4ZOhMmg4OT/o u/jwNs0dixLBsayDquOfEle3oW3TA6ArYE188F0OZiJmYHe7C4Vz1v3YYskmMsN5 Lfm2wcsl60lo72XVxol8n/ZoH5FHVjyt4gHBu6+ps0KCpyqN+b+9Ho8SIQQyweqA Bo0Tiy434p8ut0hlxc1xU1GhGALI5SqbsxoLCm/mR1fkxh3GrHwTqgsXf6MoLCx0 khkrfrp9Z7WjinDB+x8AUE0sI4278FuAI6Yc0FCklg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdejgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufhtvghvvghn ucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmqeenucggtffrrg htthgvrhhnpedvkeehkeegleehheeggfduleektefhhffgueffteekgedtvdefuddutddt jeejvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jun 2024 12:20:37 -0400 (EDT) From: Steven Allen To: Suhail Singh , Ihor Radchenko Cc: emacs-orgmode@gnu.org, Bastien Subject: Re: [POLL] We plan to remove #+LINK: ...%(my-function) placeholder from link abbreviation spec In-Reply-To: <87cyo13w0x.fsf@gmail.com> References: <87sex5gdqc.fsf@localhost> <87wmm96r53.fsf@localhost> <87cyo13w0x.fsf@gmail.com> Date: Fri, 28 Jun 2024 09:20:36 -0700 Message-ID: <87pls1ox7v.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=103.168.172.150; envelope-from=steven@stebalien.com; helo=fout7-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: B6B603D405 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -10.00 X-Spam-Score: -10.00 X-TUID: 7o5xB67Z1X/0 Suhail Singh writes: > Ihor Radchenko writes: > >> If you are actively using #+LINK: keywords with %(...) placeholders or >> have any objections to this feature removal, please let us know. > > I do not actively use this feature, however, removing it seems > excessive. IIUC, it's a useful feature in situations when the tag may > require deterministic, yet non-trivial manipulation. The current > mechanism of restricting this to functions marked safe by user seems > sufficient. > > Am I missing something? Is the threat model such that it can only be > adequately addressed by removing the feature altogether? There are two issues: 1. While this feature no longer invokes completely arbitrary code, it still allows an attacker to call any function marked as "pure" which is a pretty large attack surface. 2. Making it secure also made it significantly less useful, if it ever was all that useful. For the %(...) specifier to be useful, you need a pure/safe function that takes exactly one string argument and produces the string you need. You can, of course, write that function; but then you might as well use org-link-abbrev-alist instead of defining a local #+LINK. Personally, I'd start by forbidding %(...) placeholders in buffer-local #+LINK: definitions, they're perfectly safe in org-link-abbrev-alist.