From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uKHrKNHU5maQ6gAA62LTzQ:P1 (envelope-from ) for ; Sun, 15 Sep 2024 12:36:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id uKHrKNHU5maQ6gAA62LTzQ (envelope-from ) for ; Sun, 15 Sep 2024 14:36:33 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Z4CKilzP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726403793; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=hbJk6NTQqKnZUGX5zKEnVZZznMb3JBfPdjhqQ8ohbOk=; b=nRMD4HmthYHjfqYnqkqqX3P4RsGIRpVND5kDP93HJq4xJTGid8a+vZ3ZPnaeO3s++jfwS2 B6TEsPv0peykyuQ3QJ7fZEFt9ZaFfPdCreemGBgbwSbzVj2DJOIpM66b3cth6FdQOGQ66H UVAIyt5gDb84AlqgWK/4+H/HnrEoWuJVPOcSxzXT4h6/0xm0I8ZYhNpVlngvC9N8xCbLle uJXVPNqZLs9O4tZRdo6shkM9nkJT0LGwZVFg2O/w06+uKMfaXlcHxJT1i6d3vwNrhmeh2b HHb0PPehYBppUFKeau0OUMForTcKjfdqDOXDSsWjD2kE16vP3q/fK1UUKn5IWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Z4CKilzP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726403793; a=rsa-sha256; cv=none; b=d5AgrK0D+A2YCBVW0goj6uRyqToLka48WCs/RHaEZzrIyVSOoZbvbEnFMvPDWI3kAO9U3+ AvdtvsrkGzlvrAeNZQHxze3Hl2SFzX9rmsP4SBvw2A/iLmNFBvIvoaKcaTxf3RCmF2Uipy yu0vH7qeEPu0b84pkXtM4LPmd0rMyFbZmFbOFkQNQgDiT7fNht/MNPnlZrXdvgku8domOm LgCQ4DkN9ZDm6aaM7VCcRUkYlpZaaNodP9x2+u7YSt6+BqjAzE5bu0Mz9u4h+To+y6NM4N n2J0HjJ+gZF7WRVY5w4vOOc2Zr//ygLtxAelAmyH8V95hlbT6eFUkmZU/tk2Vw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7AE957D5D4 for ; Sun, 15 Sep 2024 14:36:33 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spoU4-0002Hl-IK; Sun, 15 Sep 2024 08:36:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spoU2-0002H9-Fw for emacs-orgmode@gnu.org; Sun, 15 Sep 2024 08:36:06 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spoTy-0001Ws-55 for emacs-orgmode@gnu.org; Sun, 15 Sep 2024 08:36:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 689E3240101 for ; Sun, 15 Sep 2024 14:36:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726403760; bh=t196CCxFfbHxYWxmO+KsIeDFJ152ctrD0pKJpdS16CY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=Z4CKilzP09n1ci6c0VML5wgb7bE6Mx7xaOEpW7DsMPVe+Y2r7b8sbzAUUNl/rZtJM 7FszegDKHOKIc0XveaWdqqbRwyJM2Ap4Cg1D8JmUuqihQhDypVbmPIqaV4huIm0Elf JQ0XIQg+EAo3JAYIKFg51xD5Nm2/9Ww2cZGaZBfe9czeLKNzyuvjvidpqjm3KW58xQ hk9Omh5MlewztS8DtV2haSCeg+Nlf4CF/oTJh+dkiDi4nDwT5ma0jglsY41wthsrvG fJDDF+z/QGZiDzgqwMyW5lbotoXStnq6t8/Q1rcsYXrsgYGDfRsHCrhy20NLBELe+i wzZuvbvZogdXg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X66wH54xvz9rxK; Sun, 15 Sep 2024 14:35:59 +0200 (CEST) From: Ihor Radchenko To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ox-texinfo: Support links in headings In-Reply-To: <20240831203526.31509-1-rudolf@adamkovic.org> References: <20240831203526.31509-1-rudolf@adamkovic.org> Date: Sun, 15 Sep 2024 12:37:30 +0000 Message-ID: <87plp53xf9.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 7AE957D5D4 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -9.73 X-Migadu-Spam-Score: -9.73 X-TUID: lx86Fk6M2MhL Rudolf Adamkovi=C4=8D writes: > From: Rudolf Adamkovic > > * etc/ORG-NEWS (Texinfo exporter now supports links in headings): > Announce the new feature. > * lisp/ox-texinfo.el: (org-texinfo--format-entries, > org-texinfo--get-node, org-texinfo--sanitize-title-reference, > org-texinfo--sanitize-title): A 2-step change: (1) Rename > `--sanitize-title' to `--sanitize-title-reference' and (2) create a > new `--sanitize-title' sanitation function. The new function is less > strict in that does not remove links, which should be allowed in > sectioning commands, such as `@unnumbered'. The old function remains > more strict, which is useful for generating `@node' names, for > example. > * testing/lisp/test-ox-texinfo.el: > (test-ox-texinfo/headings-with-links): Test the new functionality to > avoid regressions in the future. Thanks! I tried to run make test and your new test fails: Test test-ox-texinfo/headings-with-links condition: (search-failed "^@chapter Heading 2 (@ref{Heading 1})$") May you please fix this and also rebase the patch onto the latest main? --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at