emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: "Rudolf Adamkovič" <rudolf@adamkovic.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-texinfo: Support links in headings
Date: Sun, 15 Sep 2024 12:37:30 +0000	[thread overview]
Message-ID: <87plp53xf9.fsf@localhost> (raw)
In-Reply-To: <20240831203526.31509-1-rudolf@adamkovic.org>

Rudolf Adamkovič <rudolf@adamkovic.org> writes:

> From: Rudolf Adamkovic <rudolf@adamkovic.org>
>
> * etc/ORG-NEWS (Texinfo exporter now supports links in headings):
> Announce the new feature.
> * lisp/ox-texinfo.el: (org-texinfo--format-entries,
> org-texinfo--get-node, org-texinfo--sanitize-title-reference,
> org-texinfo--sanitize-title): A 2-step change: (1) Rename
> `--sanitize-title' to `--sanitize-title-reference' and (2) create a
> new `--sanitize-title' sanitation function.  The new function is less
> strict in that does not remove links, which should be allowed in
> sectioning commands, such as `@unnumbered'.  The old function remains
> more strict, which is useful for generating `@node' names, for
> example.
> * testing/lisp/test-ox-texinfo.el:
> (test-ox-texinfo/headings-with-links): Test the new functionality to
> avoid regressions in the future.

Thanks!

I tried to run make test and your new test fails:

Test test-ox-texinfo/headings-with-links condition:
    (search-failed "^@chapter Heading 2 (@ref{Heading 1})$")

May you please fix this and also rebase the patch onto the latest main?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-09-15 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-31 20:35 [PATCH] ox-texinfo: Support links in headings Rudolf Adamkovič
2024-09-15 12:37 ` Ihor Radchenko [this message]
2024-09-15 21:12   ` Rudolf Adamkovič
2024-09-16 19:00     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plp53xf9.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=rudolf@adamkovic.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).