From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YHmYEHhtImcBXgAAqHPOHw:P1 (envelope-from ) for ; Wed, 30 Oct 2024 17:31:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id YHmYEHhtImcBXgAAqHPOHw (envelope-from ) for ; Wed, 30 Oct 2024 18:31:36 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=QnwGthVr; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730309496; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=y6qdhikYaDj43D23jNLw8A39oBFnUElqKfGwTodLIcs=; b=osDYHP4uFWwjLBeQGec1f9xdrQ8EBBj3++VqUW4EbuyrEaHaqNBnmk6Avyf4a4qS8P9jz7 iVYARiz4ozy7s9dTk+DA4hg6Ml2jVSi9rKFBqGCohLE/kMe+ZMnSKW2Lg5bB0gqCa5YheP 3TSyCAPLfoQBsEdsJ3KjPhwxTTPg8YWLgY5OQTzQvOn2gMV0D8Xx6rsCK93bQbRzoWLFY/ zdKjpvmYpLIKeNyE6iLhDKop0q+s2xGvLQ5sPg4O22ZUzuX6XfM57jZoxLlZoL4hii3prT CVlDYIFJ2iP6q2GPWLgh6mio0DckT8sKrefWvyEC/+2ekidlSS5fioNPMqEDOg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730309496; a=rsa-sha256; cv=none; b=qEFDbJn9Gu4TvKlQJlmkpheHrWtmEPIhbToZ8vZtLHG0cjUlcOV8kYoGtdVPC+CxIWiDQb GnJT8uDcJGYbB2jed6dBYWe6EbmAPZpenLqxtrNs1DPjVUip7AiEWdVjqz3QiVtkxQwqs2 oFv2x9qOK01MtryW1nql5o5387oa7ftEUnxeCbkObMvdB/HXreRYJzG0qmxPlS7B9NAjbx i/dzgyyboc5q2Mq588fbm16ZZVtbUnNFslCPQCWIGBNxS+5CU8TzIrz2ahscVYksQRnFRu b+7CsoxX3Jxo/8jXxjkArYRqDi3GUehp3eGGXEPQCsWNeex+xOpfOw4zu+Jn5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=QnwGthVr; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 92E9D7CE0 for ; Wed, 30 Oct 2024 18:31:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6CWr-0003GS-PY; Wed, 30 Oct 2024 13:30:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6CWi-0003GJ-PU for emacs-orgmode@gnu.org; Wed, 30 Oct 2024 13:30:37 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6CWg-0004Js-IV for emacs-orgmode@gnu.org; Wed, 30 Oct 2024 13:30:36 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EC9B8240027 for ; Wed, 30 Oct 2024 18:30:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730309431; bh=WblIZpY44sesrNe18IiUeGKsmOx3vlscHg/nny3IFl4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=QnwGthVr0nAEEtEYqxHoo5MaTbBJRUO/ImnfEHvCDC6tg93+tpso02A/eHcKMSm75 JfnOUYTB270LtyD+sUhDeqRuHJaLX3X1diNb+VbTW+T56hil7LknKtKUAKuZ00ojl6 hp/KFbGeS79ir7NEDRO4L5QxS85m3eucnpnPshUrr/OyXz7lt13lFtTbPYAkKCgAMC BqiVH0qkQA2aKE/+7jrU22vuFCKVdm0LAamkwvpQVf7mypuu7dUmn7YuMz7poPI02P RkLl+xJfY6VVkbtZKDMoT2nFNIiqUFr7kf3cHqw5s2lRmW/8aK4tR/ewByrunvLgE1 gjw9Xgh/QsSJQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XdvKL4sd0z6tyj; Wed, 30 Oct 2024 18:30:30 +0100 (CET) From: Ihor Radchenko To: Karthik Chikmagalur Cc: stardiviner , Org mode Subject: Re: [PATCH v10] Inline image display as part of a new org-link-preview system In-Reply-To: <87msimtz88.fsf@gmail.com> References: <6461a84b.a70a0220.b6d36.5d00@mx.google.com> <878qwb8qw1.fsf@localhost> <878qw9ak6a.fsf@gmail.com> <87o74ypp3b.fsf@localhost> <87r09rxpjg.fsf@gmail.com> <87h6ah72ui.fsf@localhost> <8734m060ma.fsf@gmail.com> <87o74mjgcy.fsf@localhost> <8734lx4twk.fsf@gmail.com> <87bk0hs4dm.fsf@localhost> <87tte7wdpj.fsf@gmail.com> <87y135ce4g.fsf@localhost> <87cykbfodz.fsf@gmail.com> <87r08nkhfg.fsf@localhost> <874j5jfy8y.fsf@gmail.com> <875xpxu47h.fsf@localhost> <87h68weovw.fsf@gmail.com> <875xpcks8a.fsf@localhost> <87a5enevy5.fsf@gmail.com> <877c9qeohj.fsf@localhost> <87msimtz88.fsf@gmail.com> Date: Wed, 30 Oct 2024 17:32:14 +0000 Message-ID: <87plnh7azl.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.28 X-Spam-Score: -4.28 X-Migadu-Queue-Id: 92E9D7CE0 X-Migadu-Scanner: mx13.migadu.com X-TUID: rOGKkF66Ac2A Karthik Chikmagalur writes: > I have one more question for you: > > The overlay property that is used to check if it corresponds to a link > preview is inconsistent with the rest of Org right now. We are checking > for the non-nil overlay property `org-image-overlay'. > > 1. Should we rename this property to `org-link-preview-overlay', or > `org-link-preview'? > > 2. Org's LaTeX previews (both the existing and WIP versions) use a > different system. They set two overlay properties: `category' set to > `org', and `org-overlay-type', set to `org-latex-preview'. Should we > use a consistent set of properties to identify Org-related overlays? May you elaborate on why you went with category = 'org? category property has a special meaning in overlays. > This is an implementation detail and none of it really matters, but I > can unify them if required. What I am certain about is that we do need to keep `org-image-overlay' property as it might be used by third-party code. We may add something extra to make things more consistent across Org mode, but `org-image-overlay' must be kept for backwards compatibility reasons. > +Org mode can display previews of [[*Hyperlinks][hyperlinks]] inside Org buffers. By I just started doing a final pass of the proofreading and figured that we should not use links to other parts of the manual or other manuals that have description. This is because texinfo formats them unexpectedly, as Section X.X [description], page YYY. May you please run make docs with your patch and look into the results org.pdf file? We need to make sure that things the new section is readable there. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at