From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id AHS7Krzzg2eCGQAAqHPOHw:P1 (envelope-from ) for ; Sun, 12 Jan 2025 16:54:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id AHS7Krzzg2eCGQAAqHPOHw (envelope-from ) for ; Sun, 12 Jan 2025 17:54:20 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=cu9VLM7i; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736700860; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LZLNkhGEJRI8naXqCZvlHHHTeRhiw3IyfzMOjlLqf1I=; b=lLMd2w6JmQGA1u7nMSGE6wkbVu5qB39z6AztZDpRMZOcLavh+/pfMiBMtg0r2YwRMSy6i6 uIAKCZyfGK2oI6Ai/Q2/9Yaf8jGed/IT3NsWe/86bJvAHlLjIoNMWfuRdzAB5JgvjbFtjr kiI8UaeUyysjMylBmiORWS9PgPkGk6fo20L9qSbtiUhHZGSD+cD1e62SWez+cHcR7zK1uk 37thVhNZOtMPnFvubpynTiRjleRpRpGlp6InSeUDVaDg1cM2pfRl48RKOgJjOwLR5oA5Ii TDbXzFBb4RuMdhxhtjVFLlh2m01oouKdJDK+lLKUGRMOGKNkm3GWkhPNd0pv0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=cu9VLM7i; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736700860; a=rsa-sha256; cv=none; b=kww4j2AtbSEByarVvGYp5hLTJqfyDO0gY0EIbSQgazAlppuMn0eyBEEzvteR2K7qLzUphN beksU0iDNNY8sf+5OoXXcGeiekhFlgU/qQJu88ndOCVIAgNHiSCGFS5XPWMVDxrQDsJdsH P3rvUX3VGNMLsPFC5vXBBZilqDEg9wxQ99Tde6j0y9A74bR/jYTB9PILhJ0eNXWkspV/v/ 7h3tk67uuRp3+Cl1ksz3Cdpp3EL6CvS0sebdxCAS803mccmUDxZpA1wLIprV/CfS+1YZfa dUVBqb50IjhHacEHjrOq+s+akdQK7HuFRInRoZIdiF1NsVlTwljhBbp3E+3wkA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D6DE6504DD for ; Sun, 12 Jan 2025 17:54:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tX1DU-0005LJ-F7; Sun, 12 Jan 2025 11:53:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tX1DR-0005Ku-VL for emacs-orgmode@gnu.org; Sun, 12 Jan 2025 11:53:33 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tX1DP-0003tE-Hr for emacs-orgmode@gnu.org; Sun, 12 Jan 2025 11:53:33 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 20CC4240101 for ; Sun, 12 Jan 2025 17:53:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1736700809; bh=6OihGiwdCabfsXBo8neDF+tA3q8+v3vYuIxPk68/CEU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=cu9VLM7iIEg4N1WqRS59B2s95dqelpQmD2XBRpi4FwWA/7W1f74fF4Q82Di251fzX C/G+pLZxK6r9f/GwKvgaV1+t9RUdwTILDaVu2hmEiai/+tM1Ya03XI9EKCF/JNClM+ FbVlnjjxZHggO62ltgAQSXsgQPSyRryNtNCzx48uslQEVGo8dpP/2Yil12nhIgX1mc ir+AJVLUVbwYXDTvYzSiBOwerzpkOLSPBBRRbC9vITzxpeWEyaJWamtDxV3KVHv4WX UFvpd7hJiVobvLyl+iZOVyMNuYLcj0Ei0ntI224xehl91ddiPJX7zwEq6NkX5Pxhwh DS4x1CcqiYfjA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YWM0S3yPSz9rxG; Sun, 12 Jan 2025 17:53:28 +0100 (CET) From: Ihor Radchenko To: Slava Barinov Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-collector.el: Add support for TBLFM In-Reply-To: <20241207035621.147856-1-rayslava@gmail.com> References: <20241207035621.147856-1-rayslava@gmail.com> Date: Sun, 12 Jan 2025 16:55:47 +0000 Message-ID: <87plksx97w.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: D6DE6504DD X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: 0.05 X-Spam-Score: 0.05 X-TUID: p5idnlBQpj+8 Slava Barinov writes: > The :tblfm keyword adds formulas to the end of table so they are applied right > after collection is done and the table is generated. > > * lisp/org-collector.el (org-dblock-write:propview): Add support for the > :tblfm keyword. Thanks for the patch, and do note that org-collector and other libraries in org-contrib repository are only maintained minimally. If you are an active user of org-collect and willing to contribute to it, may I suggest you to consider stepping up as a maintainer? See https://git.sr.ht/~bzg/org-contrib > + (when tblfm > + (save-excursion > + (goto-char (point-min)) > + (when (re-search-forward "^#\\+TBLFM:" nil t) > + (setq tblfm-pos (match-beginning 0)) > + (delete-region tblfm-pos (line-end-position)))) > + (unless (looking-back "\n" 1) > + (insert "\n")) > + (insert (concat "#+TBLFM:" tblfm))) I am not familiar with org-collector code, but (goto-char (point-min)) seems dangerous - what if current Org buffer has multiple tables with TBLFM lines? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at