From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: BUG?: repeat items disappears in agenda Date: Sun, 20 Jan 2008 11:51:42 -0500 Message-ID: <87odbgtp7l.fsf@gollum.intra.norang.ca> References: <4790CE1B.8040701@gmail.com> <874pdaomid.fsf@uiuc.edu> <7B164E1D-3884-4BBF-AB2B-E90068254CEF@science.uva.nl> <20080118215529.GG17250@seeker.homedns.org> <48F709E7-8D83-4021-8AA1-4AB71A9ECE53@science.uva.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGdOj-0000OW-8P for emacs-orgmode@gnu.org; Sun, 20 Jan 2008 11:51:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGdOg-0000N4-0n for emacs-orgmode@gnu.org; Sun, 20 Jan 2008 11:51:52 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGdOf-0000Mz-Mh for emacs-orgmode@gnu.org; Sun, 20 Jan 2008 11:51:49 -0500 Received: from mho-02-bos.mailhop.org ([63.208.196.179]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JGdOf-0003IC-6X for emacs-orgmode@gnu.org; Sun, 20 Jan 2008 11:51:49 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org, Dennis J Lin I'm using the agenda to keep my important tasks 'in my face' so they get dealt with. This is normally the only place my repeating tasks show up. If I miss a repeating task for a few days for some reason the worst thing (for me) that can happen is it falls off the agenda for some time without being completed. In that case I lose it until it comes up again and now it's really late. It's fine if the date resets on the next repeating date if it remains undone that long but I'd really prefer the task to stay on the agenda no matter what - until it is completed (and moves to some future date). Just my two cents :) Bernt Carsten Dominik writes: > Hi Dennis, thanks for the patch. > > I am not sure yet if you are using the right condition though. It > seems to me that extending the late-warning-period makes sens only for > repeating *tasks*, where the base date keeps changing each time you > mark this entry as DONE. So maybe the condition should be that it is > today *and* that the item is a task marked by a TODO keyword. > > Or: maybe for Scheduled, we should no relate to the *nearest* match of > the repeater, but to the most recent one. This way you would get > over- > due warnings right up to the day where the next occurrence of this > item is scheduled. So you would never loose sight on the item. > > Hmmmm. More discussion please! > > - Carsten > > On Jan 18, 2008, at 10:55 PM, Dennis J Lin wrote: > >> Salutations! >> >>> Please post your code, you can always do this, the copyright question >>> only star when we decide to use it. And even then, 4 lines is very >>> little. >> >> Sure, please see it below :-) >> >> Dennis Lin >> >>>> >>>> Basically, in org-agenda-get-scheduled, we call >>>> org-time-string-to-absolute passing in d1 (the day that we're trying >>>> to get agenda items for.) The problems is that if d1 is today, we >>>> will get the closest day, which may be in the future, leading to the >>>> problem. The patch that I've found was to not pass in d1 if >>>> todayp is >>>> true. >>>> >>>> I have a 4 line patch implementing this (and I probably should write >>>> another one to fix a similar problem with deadlines), but I've not >>>> signed a FSF release, so I don't know if you want me to post my code >>>> here. >> >> Now, this patch is now quite old (it was for 5.08) but it should still >> apply cleanly. Looking at it, it might be whitespace damaged, and >> there should be a similar change for the get-deadline. However, I >> think it gets the idea across (and seems to fix the problem for me.) >> >> Dennis Lin >> >> --- old/org.el 2007-09-05 03:16:41.000000000 -0500 >> +++ new/org.el 2007-09-09 00:50:36.000000000 -0500 >> @@ -18676,7 +18676,9 @@ >> (org-agenda-skip) >> (setq s (match-string 1) >> pos (1- (match-beginning 1)) >> - d2 (org-time-string-to-absolute (match-string 1) d1) >> + d2 (if todayp >> + (org-time-string-to-absolute (match-string 1)) >> + (org-time-string-to-absolute (match-string 1) d1)) >> diff (- d2 d1)) >> (setq pastschedp (and todayp (< diff 0))) >> ;; When to show a scheduled item in the calendar: > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode