From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [odt] htmlfontify + Support for src blockfontification
Date: Fri, 19 Aug 2011 22:20:31 +0200
Message-ID: <87obzlcfw0.fsf@gnu.org>
References: <81ty9i1kg5.fsf@gmail.com> <877h6cfk68.fsf@altern.org>
	<814o1elfkj.fsf@gmail.com> <87ei0hrgcz.fsf@altern.org>
	<81wre9yfmx.fsf@gmail.com> <87bovllmot.fsf@gnu.org>
	<81ei0hk2fi.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:44861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1QuVXm-0006E4-Oq
	for emacs-orgmode@gnu.org; Fri, 19 Aug 2011 16:19:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1QuVXl-0005Mt-Qr
	for emacs-orgmode@gnu.org; Fri, 19 Aug 2011 16:19:54 -0400
Received: from mail-ww0-f49.google.com ([74.125.82.49]:60822)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1QuVXl-0005Mj-IR
	for emacs-orgmode@gnu.org; Fri, 19 Aug 2011 16:19:53 -0400
Received: by wwf10 with SMTP id 10so2759443wwf.30
	for <emacs-orgmode@gnu.org>; Fri, 19 Aug 2011 13:19:52 -0700 (PDT)
In-Reply-To: <81ei0hk2fi.fsf@gmail.com> (Jambunathan K.'s message of "Fri, 19
	Aug 2011 18:01:45 +0530")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Jambunathan K <kjambunathan@gmail.com>
Cc: emacs-orgmode@gnu.org

Jambunathan K <kjambunathan@gmail.com> writes:

>> +(defcustom org-export-odt-use-htmlfontify t

The name of the variable is confusing -- we should mention this is 
about src block.

>> +  "Specify whether or not source blocks need to be fontified.
>> +Turn this option on if you want to colorize the source code
>> +blocks in the exported file.  For colorization to work, you need
>> +to make available an enhanced version of `htmlfontify' library."
>>
>> For now, the correct default value is `nil', otherwise users will 
>> encounter problems.
>
> No. There is an in-built deprecation as below:
>
> #+begin_src emacs-lisp
>    (if (and org-export-odt-use-htmlfontify
> 	    (or (featurep 'htmlfontify) (require 'htmlfontify)) 
> 	    (fboundp 'htmlfontify-string))
>       ...)
> #+end_src

Is it useful to set `org-export-odt-use-htmlfontify' to `t' in the 
absence of `htmlfontify-string'?  If not, let's bind it to `nil' and 
wait for `htmlfontify-string' to be available for turning it on by 
default.

Thanks,

-- 
 Bastien