emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: nicholas.dokos@hp.com
Cc: "András Major" <andras.g.major@gmail.com>,
	emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Bug: named columns in tables not working if name contains "_"
Date: Tue, 23 Aug 2011 16:35:30 +0200	[thread overview]
Message-ID: <87obzgyuna.fsf@altern.org> (raw)
In-Reply-To: <12806.1314107627@alphaville.dokosmarshall.org> (Nick Dokos's message of "Tue, 23 Aug 2011 09:53:47 -0400")

Hi Nick,

Nick Dokos <nicholas.dokos@hp.com> writes:

> Try adding an underscore to the regexp on line 2179 of org-table.el -
> something like this (untested):
>
>           ...
> 	  (if (string-match "^[a-zA-Z][a-zA-Z0-9_]*$" name)
> 	      (push (cons name (int-to-string cnt)) org-table-column-names))))
>
> The only characters permitted are alphanumerics. That can probably be
> easily relaxed.

Thanks for the suggested fix.

I've pushed a change to allow the underscore char in both field and
column names.

Best,

-- 
 Bastien

  parent reply	other threads:[~2011-08-23 16:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23 13:20 Bug: named columns in tables not working if name contains "_" András Major
2011-08-23 13:53 ` Nick Dokos
2011-08-23 13:58   ` Bug: named columns in tables not working if name contains András Major
2011-08-23 14:34     ` Bastien
2011-08-23 14:08   ` Bug: named columns in tables not working if name contains "_" Carsten Dominik
2011-08-23 14:32     ` Nick Dokos
2011-08-23 14:49       ` Carsten Dominik
2011-08-23 16:20     ` Bastien
2011-08-23 16:47       ` Carsten Dominik
2011-08-23 18:29       ` Carsten Dominik
2011-08-23 18:54         ` Bastien
2011-08-24 20:15         ` Michael Brand
2011-08-24 20:39           ` Nick Dokos
2011-08-23 14:35   ` Bastien [this message]
2011-08-23 16:24   ` Achim Gratz
2011-08-24 20:32     ` Michael Brand
2011-08-24 20:46       ` Nick Dokos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obzgyuna.fsf@altern.org \
    --to=bzg@altern.org \
    --cc=andras.g.major@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nicholas.dokos@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).