Bug: Remote state change of repeating TODO fails with calendar open [7.8.03]

Bug: Remote state change of repeating TODO fails with calendar open [7.8.03]

[Thomas Morgan]

Changing a repeating TODO's state to DONE remotely from the
agenda fails to change the date when the calendar is open in
another window.

The reason is that `org-recenter-calendar' selects the agenda
window after doing its work, also making the agenda the current
buffer, but caller `org-auto-repeat-maybe' expects the current
buffer to be the Org file that contains the TODO item.

Here's how to reproduce it:

Run `emacs -Q -l setup.el'.
Type `M-x calendar'.
Type `M-x org-agenda', then `a' for weekly agenda.
Move point to first TODO.
Press `t' to try to change TODO state to DONE.

The result is that `Note stored' appears in the echo area but
there is no change in the agenda view or in the scheduled date
in `test-case.org'.

Here is `test-case.org':

------------------------------------------------------------------------

* TODO Foo
  SCHEDULED: <2012-02-17 Fri .+1d>

------------------------------------------------------------------------

And here is `setup.el':

------------------------------------------------------------------------

(setq org-agenda-files '("./test-case.org"))

------------------------------------------------------------------------

Emacs  : GNU Emacs 24.0.93.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2012-02-09 on tyl
Package: Org-mode version 7.8.03

current state:
==============
(setq
 org-export-blocks '((src org-babel-exp-src-block nil) (comment org-export-blocks-format-comment t) (ditaa org-export-blocks-format-ditaa nil)
		     (dot org-export-blocks-format-dot nil))
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
 org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
 org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
 org-babel-pre-tangle-hook '(save-buffer)
 org-occur-hook '(org-first-headline-recenter)
 org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src org-babel-exp-inline-src-blocks))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
 org-blank-before-new-entry nil
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
		 org-babel-hide-all-hashes)
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc org-beamer-auto-fragile-frames
			       org-beamer-place-default-actions-for-lists)
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-agenda-files '("./test-case.org")
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-confirm-shell-link-function 'yes-or-no-p
 )

Re: Bug: Remote state change of repeating TODO fails with calendar open [7.8.03]

[David Maus]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

Hi Thomas,

At Fri, 17 Feb 2012 14:28:39 +0100,
Thomas Morgan wrote:
>
> Changing a repeating TODO's state to DONE remotely from the
> agenda fails to change the date when the calendar is open in
> another window.
>
> The reason is that `org-recenter-calendar' selects the agenda
> window after doing its work, also making the agenda the current
> buffer, but caller `org-auto-repeat-maybe' expects the current
> buffer to be the Org file that contains the TODO item.
>
> Here's how to reproduce it:
>
> Run `emacs -Q -l setup.el'.
> Type `M-x calendar'.
> Type `M-x org-agenda', then `a' for weekly agenda.
> Move point to first TODO.
> Press `t' to try to change TODO state to DONE.
>
> The result is that `Note stored' appears in the echo area but
> there is no change in the agenda view or in the scheduled date
> in `test-case.org'.

Thanks for the report and the detailed analysis. I pushed a fix for
this problem, could you pull and check if the problem is fixed for
you?

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]

Re: Bug: Remote state change of repeating TODO fails with calendar open [7.8.03]

[Thomas Morgan]

Hi, David,
Thanks, that fixes it for me.
Best wishes,
Thomas