From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [bug] Can't find remote table when name is downcased
Date: Mon, 02 Apr 2012 17:49:01 +0200
Message-ID: <87obraw2vm.fsf@gnu.org>
References: <80398mutmp.fsf@somewhere.org> <87aa2uxjgt.fsf@gnu.org>
	<808viegn8a.fsf@somewhere.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:56181)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SEjTz-0003sm-RT
	for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 11:47:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SEjTx-0005EU-Pq
	for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 11:47:51 -0400
Received: from mail-we0-f169.google.com ([74.125.82.169]:49404)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SEjTx-0005EH-HH
	for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 11:47:49 -0400
Received: by werj55 with SMTP id j55so2341368wer.0
	for <emacs-orgmode@gnu.org>; Mon, 02 Apr 2012 08:47:47 -0700 (PDT)
In-Reply-To: <808viegn8a.fsf@somewhere.org> (Sebastien Vauban's message of
	"Mon, 02 Apr 2012 17:36:05 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org

--=-=-=
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Hi Sébastien,

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> Bastien wrote:
>> "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
>>
>>> The error
>>>
>>>     if: Can't find remote table "onsite"
>>>
>>> is reported if the table name is in downcase (as in the following
>>> example).
>>
>> Can you try this patch and report?
>
> 1. Applied the patch manually.
> 2. Restarted Emacs (to be sure, as it is a defconst).
> 3. Tested.
>
>    But, no, it does not work on the provided example: remote table is still
>    not found.

Please test this new patch.

I won't apply this before we sort out the conventions around using
downcase/uppercase keywords, as Ilya stated a while ago.

Thanks,


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=fix-tbl-line-downcase2.patch

diff --git a/lisp/ob.el b/lisp/ob.el
index 726245c..49ce76a 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -439,3 +439,3 @@ specific header arguments as well.")
 
-(defvar org-babel-data-names '("TBLNAME" "RESULTS" "NAME"))
+(defvar org-babel-data-names '("tblname" "results" "name"))
 
diff --git a/lisp/org-table.el b/lisp/org-table.el
index ae12cee..4bf025b 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -3828,3 +3828,3 @@ Use COMMAND to do the motion, repeat if necessary to end up in a data line."
 (defconst orgtbl-line-start-regexp
-  "[ \t]*\\(|\\|#\\+\\(TBLFM\\|ORGTBL\\|TBLNAME\\):\\)"
+  "[ \t]*\\(|\\|#\\+\\(tblfm\\|orgtbl\\|tblname\\):\\)"
   "Matches a line belonging to an orgtbl.")
@@ -4734,3 +4734,3 @@ list of the fields in the rectangle ."
 	    (if (re-search-forward
-		 (concat "^[ \t]*#\\+TBLNAME:[ \t]*" (regexp-quote name-or-id) "[ \t]*$")
+		 (concat "^[ \t]*#\\+tblname:[ \t]*" (regexp-quote name-or-id) "[ \t]*$")
 		 nil t)


--=-=-=
Content-Type: text/plain


-- 
 Bastien

--=-=-=--