From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH] Let org-agenda-time-grid control if the grid is
 displayed
Date: Sat, 26 May 2012 06:27:39 +0200
Message-ID: <87obpbr2h0.fsf@altern.org>
References: <CAFDFyRh8p_shwiRuM0rRTL_dED4d0aiPqo_ro8XyEDRgqmwwAA@mail.gmail.com>
	<CAFDFyRjMqKyvC=4KK3ofBMe+taJsGrgc7r_VGf-PHEwRSXXZdA@mail.gmail.com>
	<87hav3u9t4.fsf@altern.org> <87zk8vadtp.fsf@fastmail.fm>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:50005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SY8ab-0006d2-4H
	for emacs-orgmode@gnu.org; Sat, 26 May 2012 00:26:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SY8aY-0005uo-Q3
	for emacs-orgmode@gnu.org; Sat, 26 May 2012 00:26:52 -0400
Received: from mail-we0-f169.google.com ([74.125.82.169]:38977)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SY8aY-0005uN-GY
	for emacs-orgmode@gnu.org; Sat, 26 May 2012 00:26:50 -0400
Received: by wefh52 with SMTP id h52so1218577wef.0
	for <emacs-orgmode@gnu.org>; Fri, 25 May 2012 21:26:48 -0700 (PDT)
In-Reply-To: <87zk8vadtp.fsf@fastmail.fm> (Matt Lundin's message of "Fri, 25
	May 2012 21:14:26 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Matt Lundin <mdl@imapmail.org>
Cc: emacs-orgmode@gnu.org, Christophe Junke <christophe.junke@inria.fr>

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> Bastien <bzg@gnu.org> writes:
>
>> Christophe Junke <christophe.junke@inria.fr> writes:
>>
>>> Let org-agenda-time-grid control if the grid is displayed
>>
>> Applied, thanks -- and special thanks for the ChangeLog and 
>> clear explanations.
>
> This is a problematic patch. On my machine, it causes duplicate entries
> to show up in the agenda. The reason, I believe, is because
> org-agenda-add-time-grid-maybe takes the list of agenda items and
> returns that list with time-grid stuff added. This patch appends the
> list of agenda items to the list that org-agenda-add-time-grid-maybe
> returns, thus resulting in the duplicates.

Mhh.. I've been testing too hastily.

Thanks for reporting this, I reverted the commit.

Christophe, can you look again and amend your patch if needed?

Thanks!

-- 
 Bastien