emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Matt Lundin <mdl@imapmail.org>
Cc: emacs-orgmode@gnu.org, Christophe Junke <christophe.junke@inria.fr>
Subject: Re: [PATCH] Let org-agenda-time-grid control if the grid is displayed
Date: Sat, 26 May 2012 06:27:39 +0200	[thread overview]
Message-ID: <87obpbr2h0.fsf@altern.org> (raw)
In-Reply-To: <87zk8vadtp.fsf@fastmail.fm> (Matt Lundin's message of "Fri, 25 May 2012 21:14:26 -0500")

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> Bastien <bzg@gnu.org> writes:
>
>> Christophe Junke <christophe.junke@inria.fr> writes:
>>
>>> Let org-agenda-time-grid control if the grid is displayed
>>
>> Applied, thanks -- and special thanks for the ChangeLog and 
>> clear explanations.
>
> This is a problematic patch. On my machine, it causes duplicate entries
> to show up in the agenda. The reason, I believe, is because
> org-agenda-add-time-grid-maybe takes the list of agenda items and
> returns that list with time-grid stuff added. This patch appends the
> list of agenda items to the list that org-agenda-add-time-grid-maybe
> returns, thus resulting in the duplicates.

Mhh.. I've been testing too hastily.

Thanks for reporting this, I reverted the commit.

Christophe, can you look again and amend your patch if needed?

Thanks!

-- 
 Bastien

  reply	other threads:[~2012-05-26  4:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 12:33 [PATCH] Let org-agenda-time-grid control if the grid is displayed Christophe Junke
2012-05-25 12:50 ` Christophe Junke
2012-05-25 22:20   ` Bastien
2012-05-26  2:14     ` Matt Lundin
2012-05-26  4:27       ` Bastien [this message]
2012-05-28 16:02         ` Matt Lundin
  -- strict thread matches above, loose matches on Subject: below --
2012-07-29  7:56 Christophe Junke
2012-08-07 21:44 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obpbr2h0.fsf@altern.org \
    --to=bzg@altern.org \
    --cc=christophe.junke@inria.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mdl@imapmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).