From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: Tangling is broken in git master Date: Mon, 13 Aug 2012 08:18:48 -0600 Message-ID: <87obmeg9il.fsf@gmx.com> References: <87628oncqa.fsf@norang.ca> <871ujc33gd.fsf@gnu.org> <87lihj7dyw.fsf@norang.ca> <87sjbrs5wh.fsf@gnu.org> <877gt2sy83.fsf@gmx.com> <87r4rayjxu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:43271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0vUY-0003Yq-3G for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 10:19:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0vUO-0006S5-U0 for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 10:19:38 -0400 Received: from mailout-us.gmx.com ([74.208.5.67]:42779) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1T0vUO-0006Ro-Lr for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 10:19:28 -0400 In-Reply-To: <87r4rayjxu.fsf@gnu.org> (Bastien's message of "Mon, 13 Aug 2012 15:56:29 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Bernt Hansen , emacs-orgmode@gnu.org Bastien writes: > Hi Eric, > > Eric Schulte writes: > >> I've just pushed up another version of this commit, which I believe >> removes cl-labels while still preserving tangling behavior. If you have >> a chance please re-check tangling with the latest Org-mode. > > `letrec' is not available on Emacs <24.1 > > Your commit looks like the one I pushed here... > http://orgmode.org/w/?p=org-mode.git;a=commit;h=ba16c3 > > ... and reverted, thanks to Bernt's report. > > Apart from one replacement of org-labels with `let*' in ob.el, > I don't see how we can get rid of `org-labels' completely. Oh, my apologies, I just reverted my commit. I thought letrec was an old elisp construct. I'm happy to stick with using org-labels (the code was much more readable using org-labels). I'm surprised that elisp doesn't provide any mechanism for local anonymous functions. I can't imagine why this would be an intentional design decision. Thanks, -- Eric Schulte http://cs.unm.edu/~eschulte