From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [BUG] org-agenda-open-link does not open bbdb links Date: Thu, 27 Jun 2013 15:53:41 +0200 Message-ID: <87obarr3wk.fsf@bzg.ath.cx> References: <87d2sg753q.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsDkM-0008ML-WB for emacs-orgmode@gnu.org; Thu, 27 Jun 2013 11:04:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsDkL-00021O-82 for emacs-orgmode@gnu.org; Thu, 27 Jun 2013 11:04:30 -0400 Received: from mail-wg0-x236.google.com ([2a00:1450:400c:c00::236]:58493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsDkL-00021A-17 for emacs-orgmode@gnu.org; Thu, 27 Jun 2013 11:04:29 -0400 Received: by mail-wg0-f54.google.com with SMTP id n11so660085wgh.21 for ; Thu, 27 Jun 2013 08:04:28 -0700 (PDT) In-Reply-To: <87d2sg753q.fsf@fastmail.fm> (Matt Lundin's message of "Fri, 24 May 2013 10:46:49 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Matt Lundin Cc: Org Mode Hi Matt, Matt Lundin writes: > The function org-agenda-open-link does not open bbdb links. > > The reason is that bbdb agenda lines contain links that are not found in > the entry. I'm not sure I understand. Can you provide a minimal example/recipe? > Because the agenda line is added to the strings scanned by > org-offer-links-in-entry, it is added to the list of links (lk). I.e., > both buffer and lk are defined, which triggers the first cond statement. > The function then proceeds to search for this link in the buffer. It > does not find it, since a bbdb-anniversary entry typically looks like > this: > > * Anniversaries > :PROPERTIES: > :CATEGORY: anniv > :END: > %%(org-bbdb-anniversaries) > > But as a result, the function org-offer-links-in-entry never gets to the > second cond statement, which would indeed open the link found in the > agenda buffer. > > It seems to me that feeding the agenda line as a "prefix" to > org-offer-links-in-entry is redundant, since the second cond statement > explicitly looks for links in the agenda line. > > The following change fixes the problem, but before I submit it as a > properly formatted patch, I want to make sure that it does not interfere > with some other functionality. The patch would need to update `org-offer-links-in-entry' too, as the occurrence you changed is the only one requiring a zero arg. I remember this was intentional, but the code is convoluted here. Anyway, a recipe on how to reproduce the problem will help. Thanks! -- Bastien