From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [Bug] commit 39070b7fc7 breaks babel test Date: Fri, 06 Dec 2013 12:05:37 -0700 Message-ID: <87ob4t6b3q.fsf@gmail.com> References: <87eh622s3g.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp0wx-0004Mz-ST for emacs-orgmode@gnu.org; Fri, 06 Dec 2013 14:20:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vp0wr-0007jZ-J5 for emacs-orgmode@gnu.org; Fri, 06 Dec 2013 14:20:31 -0500 Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:39762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vp0wr-0007jN-B3 for emacs-orgmode@gnu.org; Fri, 06 Dec 2013 14:20:25 -0500 Received: by mail-pb0-f43.google.com with SMTP id rq2so1613890pbb.2 for ; Fri, 06 Dec 2013 11:20:24 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Skip Collins Cc: Achim Gratz , emacs-org list Skip Collins writes: > It's been a week and this test still fails. > Fixed. > > Would it make sense to automatically enforce passing all tests before > git accepts a change? > I for one would strongly oppose this change. This would only make it take longer and thus make it less likely that new code is committed. This is the master branch where development should be fast and experimentation should take place, not the maintenance branch. Best, > > On Wed, Nov 27, 2013 at 2:58 AM, Achim Gratz wrote: >> >> Hi Eric, >> >> this change seems to introduce additional line breaks in the following >> test: >> >> --8<---------------cut here---------------start------------->8--- >> Test test-ob/catches-all-references condition: >> (ert-test-failed >> ((should >> (string= >> (org-babel-execute-src-block) >> "A literal example\non two lines for me.")) >> :form >> (string= "A literal example\non two lines\n for me." "A literal example\non two lines for me.") >> :value nil)) >> FAILED 1/1 test-ob/catches-all-references >> --8<---------------cut here---------------end--------------->8--- >> >> This seems to happen because the final \n from the babel result is not >> stripped anymore, pointing to the change in ob-core. IIRC we >> flip-flopped a few times already with including or not including this >> final newline, so I don't know whether the code or the test should >> change. > -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D