From: Bastien <bzg@gnu.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fixed bug in org-entry-get-with-inheritance
Date: Mon, 17 Mar 2014 20:08:08 +0100 [thread overview]
Message-ID: <87ob14d4o7.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87vbvcptqt.fsf@Rainer.invalid> (Achim Gratz's message of "Mon, 17 Mar 2014 19:25:46 +0100")
Achim Gratz <Stromeko@nexgo.de> writes:
> Bastien writes:
>> Applied, thanks!
>
> That badly breaks the following tests:
>
> FAILED test-ob-header-arg-defaults/tree/accumulate/call
> FAILED test-ob-header-arg-defaults/tree/accumulate/noweb
> FAILED test-ob-header-arg-defaults/tree/complex/call
> FAILED test-ob-header-arg-defaults/tree/complex/noweb
> FAILED test-org-property-accumulation-append-use
> FAILED test-org-property-accumulation-append-val
Can you tell a bit more about what's wrong with the test?
If the patch is good and the tests are outdated, I'd rather
fix the tests than revert the patch to re-revert it again.
Thanks,
--
Bastien
next prev parent reply other threads:[~2014-03-17 19:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 6:28 [PATCH] Fixed bug in org-entry-get-with-inheritance Ilya Shlyakhter
2014-03-14 11:16 ` Bastien
2014-03-17 18:25 ` Achim Gratz
2014-03-17 19:08 ` Bastien [this message]
2014-03-17 19:20 ` Achim Gratz
2014-03-17 19:33 ` Bastien
2014-03-17 19:49 ` Achim Gratz
2014-03-17 20:35 ` Bastien
2014-03-17 20:51 ` Achim Gratz
2014-03-17 20:56 ` Bastien
2014-03-17 21:30 ` Ilya Shlyakhter
2014-03-17 21:43 ` Achim Gratz
2014-03-17 22:06 ` Ilya Shlyakhter
2014-03-17 22:13 ` Bastien
2014-03-18 12:01 ` Bastien
2014-03-18 15:14 ` Bastien
2014-03-18 15:38 ` Ilya Shlyakhter
2014-03-18 17:23 ` Achim Gratz
2014-03-18 18:27 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob14d4o7.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).