From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: Re: [RFC] Rewrite indentation functions Date: Sat, 03 May 2014 15:47:01 +0800 Message-ID: <87oazffgne.fsf@ericabrahamsen.net> References: <87oazjnf55.fsf@gmail.com> <87d2fwhh95.fsf@ericabrahamsen.net> <87fvksoctz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgUc4-0002zc-K7 for emacs-orgmode@gnu.org; Sat, 03 May 2014 03:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgUby-0004hb-Gf for emacs-orgmode@gnu.org; Sat, 03 May 2014 03:44:00 -0400 Received: from plane.gmane.org ([80.91.229.3]:50770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgUby-0004hU-9Z for emacs-orgmode@gnu.org; Sat, 03 May 2014 03:43:54 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WgUbx-0005bR-0J for emacs-orgmode@gnu.org; Sat, 03 May 2014 09:43:53 +0200 Received: from 114.248.25.95 ([114.248.25.95]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 03 May 2014 09:43:53 +0200 Received: from eric by 114.248.25.95 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 03 May 2014 09:43:53 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >> Wish I was competent to actually review this, but... In lieu of that, >> I'd be happy to run it and report errors. If you think a separate >> testing branch is warranted, that might be an idea. Otherwise I'd say >> let it drop and we'll pick up the pieces :) > > You can create a local branch in your git repo and apply the patches > I sent (be sure to use the second version of the first patch) there. > > I can certainly wait for your feedback. If it turns out to be mostly > good and no one objects, I will then apply the patches and fix the > remnant issues on master branch. Hi Nicolas, Right now I'm seeing breakage with `org-set-property' -- this only happens on the indentation patches branch. Adding an EXPORT_AUTHOR property with that command, value of "asdfadsf", gives me this: * Test Heading :PROPERTIES: :EXPORT_AUTHOR: asdfasdfnil nil Extra blank nil, spurious "nils", and no :END: I'm starting dinner and won't be able to go spelunking right now. I'll get to soon, if you aren't seeing this, or don't sort it out first. Eric