From: Bastien <bzg@gnu.org>
To: Ista Zahn <istazahn@gmail.com>
Cc: "G. Jay Kerns" <gjkerns@gmail.com>,
emacs-orgmode <emacs-orgmode@gnu.org>,
brendan.halpin@ul.ie, Eric Schulte <schulte.eric@gmail.com>
Subject: Re: Enabling another language in org-babel
Date: Tue, 29 Jul 2014 16:36:06 +0200 [thread overview]
Message-ID: <87oaw8b5bd.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CA+vqiLGxOxYVdF7VNaYNVebdDWXTSMf6vJPLnZsixKm9Zq=Xfw@mail.gmail.com> (Ista Zahn's message of "Mon, 28 Jul 2014 17:29:00 -0400")
Hi Ista,
some comments on the code below.
Ista Zahn <istazahn@gmail.com> writes:
> ;; Copyright (C) 2014 Ista Zahn
> ;; Author: Ista Zahn, based on ob-julia.el by G. Jay Kerns, and ob-R.el
> ;; by Eric Schulte and Dan Davison
You need to reformat this -- see files with multiple authors in Org or
in Emacs.
> ;; This file is not part of GNU Emacs.
We plan to add this to Org's core, so this will be part of Emacs.
> ;; Stata and ESS are required.
Maybe add some links for the requirements.
> (defcustom org-babel-stata-command inferior-STA-program-name
> "Name of command to use for executing stata code."
> :group 'org-babel
> :version "24.4"
> :package-version '(Org . "8.0")
^^^
This needs to be 8.3
> ;; The following was a very complicated write object command
> ;; The replacement needs to add error catching
> ;(defvar org-babel-stata-write-object-command "{function(object,transfer.file){object;invisible(if(inherits(try({tfile<-tempfile();write.table(object,file=tfile,sep=\"\\t\",na=\"nil\",row.names=%s,col.names=%s,quote=FALSE);file.rename(tfile,transfer.file)},silent=TRUE),\"try-error\")){if(!file.exists(transfer.file))file.create(transfer.file)})}}(object=%s,transfer.file=\"%s\")")
Maybe simply remove this, or make it more readable.
Thanks in advance for this contribution!
--
Bastien
next prev parent reply other threads:[~2014-07-29 14:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 8:54 Enabling another language in org-babel Brendan Halpin
2014-06-24 11:02 ` Eric Schulte
2014-06-24 12:05 ` Rainer M Krug
2014-06-24 19:52 ` Ista Zahn
2014-06-24 20:13 ` G. Jay Kerns
2014-06-25 8:33 ` Bastien
2014-06-25 13:44 ` Ista Zahn
2014-07-28 13:20 ` Bastien
2014-07-28 21:29 ` Ista Zahn
2014-07-29 14:36 ` Bastien [this message]
2014-07-30 16:47 ` Ista Zahn
2014-07-30 17:06 ` Nick Dokos
2014-07-30 17:16 ` Achim Gratz
2014-07-31 0:23 ` Jay Kerns
2014-07-31 10:52 ` Bastien
2014-07-31 11:06 ` Ista Zahn
2015-01-31 19:42 ` Esa Palosaari
2015-01-31 19:50 ` Esa Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaw8b5bd.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=brendan.halpin@ul.ie \
--cc=emacs-orgmode@gnu.org \
--cc=gjkerns@gmail.com \
--cc=istazahn@gmail.com \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).