Re: Bug: org-babel-ref-parse needs to set current buffer to the buffer of the marker [8.2.2 (release_8.2.2-188-gc57372 @ /home/wvxvw/Projects/org-mode/lisp/)]

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Oleg Sivokon <olegsivokon@gmail.com> writes:

> Please let me know if I didn't export the patch properly (patch
> attached).

Thank you. Some comments follow.

> From fdc1409602b48ba5f4cd1b5be6264d8311b8b11c Mon Sep 17 00:00:00 2001
> From: wvxvw <olegsivokon@gmail.com>
> Date: Fri, 8 May 2015 00:14:11 +0300
> Subject: [PATCH] Making sure the buffer pointed by
>  org-babel-current-src-block-location is active when moving to the source
>  block.

The summary line should be shorter.  Also you need to add a reference to
the function being modified, e.g.,

* list/ob-ref.el (org-babel-ref-parse): Make sure the buffer pointed by...

Eventually, you need to add "TINYCHANGE" string at the end of the commit
message if you haven't signed FSF papers.  See
<http://orgmode.org/worg/org-contribute.html#orgheadline8> for details.

>  			   (goto-char (if (markerp org-babel-current-src-block-location)
> -					  (marker-position org-babel-current-src-block-location)
> +					  (with-current-buffer
> +					      (marker-buffer org-babel-current-src-block-location)
> +					    (marker-position org-babel-current-src-block-location))
>  					org-babel-current-src-block-location)))
>  			 (org-babel-read ref))))

This won't work as `org-babel-read' is not called within the scope of
`with-current-buffer'.

I think it should be something like this:

  (with-current-buffer
      (if (markerp org-babel-current-src-block-location)
          (marker-buffer org-babel-current-src-block-location)
        (current-buffer))
    (save-excursion
      (goto-char org-babel-current-src-block-location)
      (org-babel-read ref)))

Bonus points if you can write a test about it in "test-ob.el".

Regards,