From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: a patch to ob-lisp.el Date: Mon, 28 Mar 2016 00:01:46 -0400 Message-ID: <87oa9zxnbp.fsf@pierrot.dokosmarshall.org> References: <874mbtz0pb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akONX-00052C-P5 for emacs-orgmode@gnu.org; Mon, 28 Mar 2016 00:02:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akONU-0001Z6-F9 for emacs-orgmode@gnu.org; Mon, 28 Mar 2016 00:02:11 -0400 Received: from plane.gmane.org ([80.91.229.3]:46462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akONU-0001Yv-9D for emacs-orgmode@gnu.org; Mon, 28 Mar 2016 00:02:08 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1akONM-0007jj-74 for emacs-orgmode@gnu.org; Mon, 28 Mar 2016 06:02:00 +0200 Received: from pool-74-104-149-70.bstnma.fios.verizon.net ([74.104.149.70]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 Mar 2016 06:02:00 +0200 Received: from ndokos by pool-74-104-149-70.bstnma.fios.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 28 Mar 2016 06:02:00 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org stardiviner writes: > I hope to merge this patch to Org-mode `ob-lisp.el`. > I have only looked at the surface of it, but I see some issues. > < ;; Copyright (C) 2016-2020 Free Software Foundation, Inc. > --- > > ;; Copyright (C) 2009-2016 Free Software Foundation, Inc. Why did you leave out the previous copyright statement? Where did 2020 come from? > < ;; Authors: stardiviner > < ;; Maintainer: stardiviner > < ;; Keywords: org babel lisp sly slime > < ;; URL: https://github.com/stardiviner/ob-lisp > < ;; Created: 1th March 2016 > < ;; Version: 0.0.1 > < ;; Package-Requires: ((org "8")) > --- >> ;; Authors: Joel Boehland >> ;; Eric Schulte >> ;; David T. O'Toole >> ;; Keywords: literate programming, reproducible research >> ;; Homepage: http://orgmode.org Why did you erase the previous authors? Are you volunteering to be the maintainer of ob-lisp.el or are you planning to keep your own repo and submit patches? Have you signed FSF papers? > < ;; Requires SLY (Sylvester the Cat's Common Lisp IDE) and SLIME > < ;; See: > < ;; - https://github.com/capitaomorte/sly > < ;; - http://common-lisp.net/project/slime/ > --- >> ;; Requires SLIME (Superior Lisp Interaction Mode for Emacs.) >> ;; See http://common-lisp.net/project/slime/ Does it really require both? If so, I suggest you rework it so either can be used, but only one is required. If not, I suggest you fix the comment. -- Nick