From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Feng Shu" <tumashu@163.com>
Subject: Re: (version 3) [PATCH] New feature: Use dvisvgm to preview latex
 formular
Date: Mon, 16 May 2016 13:32:42 +0800
Message-ID: <87oa86in45.fsf@163.com>
References: <87lh3dxibp.fsf@163.com> <87lh3chenz.fsf@163.com>
	<8737pjluy5.fsf_-_@163.com> <87posncycg.fsf@163.com>
	<87inyfuf4d.fsf@saiph.selenimh>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tumashu@163.com>) id 1b2BMw-0006e9-KU
	for emacs-orgmode@gnu.org; Mon, 16 May 2016 01:47:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tumashu@163.com>) id 1b2BMr-0002xX-IJ
	for emacs-orgmode@gnu.org; Mon, 16 May 2016 01:47:06 -0400
Received: from m12-15.163.com ([220.181.12.15]:43249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tumashu@163.com>) id 1b2BMq-0002xC-Hh
	for emacs-orgmode@gnu.org; Mon, 16 May 2016 01:47:01 -0400
In-Reply-To: <87inyfuf4d.fsf@saiph.selenimh> (Nicolas Goaziou's message of
	"Mon, 16 May 2016 00:32:18 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: orgmode-devel <emacs-orgmode@gnu.org>
Cc: Feng Shu <tumashu@163.com>

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:


> In any case, I suggest to create a new variable
> `org-latex-preview-process' for that.

`org-latex-preview-process' is a good idea, which make org-latex
beginner easily, i will add it.

>
>> (org-latex-compile): Add a new optional argument: caller-info,
>>                      which used to record the caller's info
>
> In the same vein, I suggest to extract it out from ox-latex and use
> a dedicated command for that.
>
> WDYT?

I suggest to add (:generator my-generator-function) style configure
to `org-latex-pdf-process', it is simple and powerful feature, we
can use this feature to switch latex commands dynamicially, for example:

(defun my-latex-pdf-process-generator (texfile snippet extra-info)
  (cond
   ((<a>) (<org-latex-pdf-process-style-command1>)
   ((<b>) (<org-latex-pdf-process-style-command2>)))))

although we can set org-latex-pdf-process to a function to do the same work,
but this function is hard to write as org-latex-compile, it may only
useful for developer instead of user....

caller-info argument is for the above feature.

>
>> (org-create-formula-image): Big refactor, merge dvipng and imagemagick backend's feature.
>>                             Add dvisvgm feature.
>
> Good news. This part was begging for a refactor. A couple (or more) of
> tests would be nice too.

yes


>> +
>> +(defalias 'org-latex-preview-ltxpng-directory 'org-latex-preview-ltximg-directory)
>> +(make-obsolete 'org-latex-preview-ltxpng-directory 'org-latex-preview-ltximg-directory
>> +	       "Org mode version 9.0")
>
> See `make-obsolete-variable'.

Remove the above two and only use the below *one* ?

(make-obsolete-variable
 'org-latex-preview-ltxpng-directory
 "Set `org-latex-preview-ltximg-directory' instead." "25.1")