From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hendrik Tews <hendrik@askra.de>
Subject: Re: Bug: right-alignment fails in column view [9.0.7
 (release_9.0.7-439-g2906e5 @ /home/tews/src/org-mode/lisp/)]
Date: Mon, 22 May 2017 10:07:02 +0200
Message-ID: <87o9uljowp.fsf@cert.kernkonzept.com>
References: <877f1e9tw5.fsf@cert.kernkonzept.com>
	<87inkvi8vn.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hendrik@askra.de>) id 1dCiO0-0005EQ-PR
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 04:08:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hendrik@askra.de>) id 1dCiNx-0005Pi-MC
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 04:08:16 -0400
Received: from askra.de ([81.169.225.145]:36702)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <hendrik@askra.de>) id 1dCiNx-0005N3-GA
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 04:08:13 -0400
Received: from ipb218494e.dynamic.kabel-deutschland.de ([178.24.73.78]
	helo=cert)
	by askra.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.84_2) (envelope-from <hendrik@askra.de>) id 1dCiMp-0006nY-4f
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 10:07:03 +0200
Received: from localhost ([::1] helo=cert.kernkonzept.com)
	by cert with esmtp (Exim 4.89) (envelope-from <hendrik@askra.de>)
	id 1dCiMo-0001FJ-NN
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 10:07:02 +0200
In-Reply-To: <87inkvi8vn.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Sat, 20 May 2017 22:14:04 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hi,

Thanks a lot for the quick fix!

I am not sure I understand the check

	 (when (or (not (string-match-p "[0-9]" value))
		   (and (string-match-p "[1-9]" value)
			(= 0 (string-to-number value))))

before the error message. Wouldn't it be good enough to apply the
format on the result of string-to-number? This would permit to
have markers "TODO" or "XXX" without getting an error.

Moreover, the test is wrong for legitimate numbers such as "0e3"
while it permits non-numbers such as "1XX". The test is also true
if the property is missing, forcing one to add the property
everywhere in the file.

Hendrik