emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Hendrik Tews <hendrik@askra.de>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: right-alignment fails in column view [9.0.7 (release_9.0.7-439-g2906e5 @ /home/tews/src/org-mode/lisp/)]
Date: Mon, 22 May 2017 10:07:02 +0200	[thread overview]
Message-ID: <87o9uljowp.fsf@cert.kernkonzept.com> (raw)
In-Reply-To: <87inkvi8vn.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 20 May 2017 22:14:04 +0200")

Hi,

Thanks a lot for the quick fix!

I am not sure I understand the check

	 (when (or (not (string-match-p "[0-9]" value))
		   (and (string-match-p "[1-9]" value)
			(= 0 (string-to-number value))))

before the error message. Wouldn't it be good enough to apply the
format on the result of string-to-number? This would permit to
have markers "TODO" or "XXX" without getting an error.

Moreover, the test is wrong for legitimate numbers such as "0e3"
while it permits non-numbers such as "1XX". The test is also true
if the property is missing, forcing one to add the property
everywhere in the file.

Hendrik

  reply	other threads:[~2017-05-22  8:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 13:28 Bug: right-alignment fails in column view [9.0.7 (release_9.0.7-439-g2906e5 @ /home/tews/src/org-mode/lisp/)] Hendrik Tews
2017-05-20 20:14 ` Nicolas Goaziou
2017-05-22  8:07   ` Hendrik Tews [this message]
2017-05-22 12:02     ` Nicolas Goaziou
2017-05-22 12:49       ` Hendrik Tews
2017-05-22 13:38         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9uljowp.fsf@cert.kernkonzept.com \
    --to=hendrik@askra.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).