From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Fix table variable with commas in ob-sqlite Date: Wed, 06 Sep 2017 13:19:56 +0200 Message-ID: <87o9qoaxb7.fsf@nicolasgoaziou.fr> References: <87zia8yhel.fsf@brickabode.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpYNJ-0008H7-IY for emacs-orgmode@gnu.org; Wed, 06 Sep 2017 07:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpYNE-0003Cf-Fk for emacs-orgmode@gnu.org; Wed, 06 Sep 2017 07:20:05 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:34047) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpYNE-0003C5-A2 for emacs-orgmode@gnu.org; Wed, 06 Sep 2017 07:20:00 -0400 In-Reply-To: <87zia8yhel.fsf@brickabode.com> (Eduardo Bellani's message of "Tue, 05 Sep 2017 18:17:22 -0300") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Eduardo Bellani Cc: emacs-orgmode@gnu.org Hello, Eduardo Bellani writes: > ob-sqlite.el: Enable table with fields containing commas to be used as > arguments to sqlite source blocks > > * lisp/ob-sqlite.el: Stop interfering with the 'orgtbl-to-csv' default > formatting. > > * testing/lisp/test-ob-sqlite.el:: Adds a test using a table with > commas in the content of any of its fields as an argument for a > sqlite source block. Use the 'org-test-with-temp-text' pattern. > > > The problem here was that ob-sqlite was providing a format to the > 'orgtbl-to-csv' that actually overwrote the default format in that > function, and in the case where there were commas in the content of the > table, broke the table as argument mechanism. Applied. Thank you. Regards, -- Nicolas Goaziou